Bug 228683

Summary:	Clicking on the 'Ok' button does not apply a template
Product:	[Applications] korganizer	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	REOPENED ---
Severity:	wishlist	CC:	aspotashev, montel, wonderz
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:

Description Sabine Faure 2010-02-26 23:55:08 UTC

Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch KOrg
- Create a new
- Reopen the event and click on 'Manage Templates...'
- Click on 'New' and enter a name for the template
- Click on 'Ok' twice
- Create a new event, click on 'Manage Templates...', select the template you've created and click on 'Ok' 

Nothing happens. The template is only applied if the user clicks on the 'Apply' button.

Trunk, Svn Rev 1096391

Comment 1 Laurent Montel 2010-02-27 13:48:05 UTC

Hi,
it's not a bug, Ok button is for valid dialogbox when we add/remove item.
But there is a label to explain how to do.
So we must click on apply to apply templates.
Regards

Comment 2 Sabine Faure 2010-03-03 18:58:30 UTC

I think the 'Manage Event Templates' dialogue should be split into two:

- one 'apply template' button leading to a 'select template' dialogue with an 'Ok' and 'Cancel' button.
- one 'create template' button leading to an 'edit template' dialogue with a new, remove, and 'ok' button.

At the moment it is really confusing for the user to select a template and click on 'Ok' since nothing happens!

Trunk, Svn Rev 1098377

Comment 3 wonderz 2010-11-26 09:13:16 UTC

Didn't want to open a separate bug, as it is a very related issue. I am ok with the apply button (although applying on cancel would definitely not hurt).

But if you prefer to have the apply button, please close the dialog once I press it. 
Why would I need to look at the dialog once a template has been applied already?

Comment 4 Sergio Martins 2011-02-27 13:14:27 UTC

Git commit 3e6c0d4715f0722ee1be598566607fc2c694713a by Sergio Martins.
Committed on 27/02/2011 at 10:52.
Pushed by smartins into branch 'master'.

Close the window after applying a template.

It's a better behavior because that's what you need most of the times.
CCBUG: 228683

M  +2    -0    incidenceeditor-ng/templatemanagementdialog.cpp     

http://commits.kde.org/kdepim/3e6c0d4715f0722ee1be598566607fc2c694713a