Summary: | rekonq crashes on ftp protocol | ||
---|---|---|---|
Product: | [Applications] rekonq | Reporter: | Rohan Garg <rohan> |
Component: | general | Assignee: | Andrea Diamantini <adjam7> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | pano_90, pprkut, rohan, webmaster |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 0.4.65 | |
Attachments: | New crash information added by DrKonqi |
Description
Rohan Garg
2010-02-26 20:45:21 UTC
Crashes here too with 0.3.96 Created attachment 41159 [details]
New crash information added by DrKonqi
Backtrace with rekonq 0.3.96,as Panagiotis Papadopoulos said,it still crashes
I cannot reproduce this bug with 0.4.53 anymore. Is it still valid? Not crashing anymore, although it still doesn't display anything ("Failed to Load"). But that's probably another bug. since it is not crashing anymore for you (and others can't reproduce it anymore), I'll put is resolved Well it has ceased to crash but it still shows failed to load,if you want a backtrace i can get one for you On Monday 26 April 2010 14:42:38 Rohan Garg wrote:
> https://bugs.kde.org/show_bug.cgi?id=228660
>
>
> Rohan Garg <rohan16garg@gmail.com> changed:
>
> What |Removed |Added
> ---------------------------------------------------------------------------
> - Status|RESOLVED |REOPENED
> Resolution|FIXED |
>
>
>
>
> --- Comment #6 from Rohan Garg <rohan16garg gmail com> 2010-04-26 14:42:33
> --- Well it has ceased to crash but it still shows failed to load,if you
> want a backtrace i can get one for you
It doesn't load because that dir in download.nvidia.com is not readable.
It crashed trying to read a not readable dir.
ftp://download.nvidia.com/XFree86/Linux-x86_64/195.36.15 works in konqueror and crashes rekonq 0.4.64 commit 77311eaf0de9fd22f42df82adf69839091cc94c8 Author: Andrea Diamantini <adjam7@gmail.com> Date: Tue Apr 27 11:50:00 2010 +0200 Remove the "is readable" check. Now things seem work. Can someone explain how can we read a not readable dir?? CCBUG: 228660 diff --git a/src/application.cpp b/src/application.cpp index d2754ec..fd03023 100644 --- a/src/application.cpp +++ b/src/application.cpp @@ -400,6 +400,9 @@ void Application::newWindow() void Application::updateConfiguration() { + // FIXME: + // all things related to mainview can be + // improved/moved/replicated in all the mainwindows MainView *view = mainWindow()->mainView(); // ============== General ================== diff --git a/src/protocolhandler.cpp b/src/protocolhandler.cpp index b88f23f..1ee026a 100644 --- a/src/protocolhandler.cpp +++ b/src/protocolhandler.cpp @@ -211,21 +211,9 @@ QString ProtocolHandler::dirHandling(const KFileItemList &list) { return QString("rekonq error, sorry :("); } - - KFileItem mainItem = _lister->rootItem(); - if (mainItem.isNull()) - { - QString errStr = i18nc("%1=an URL", "Error opening '%1': No such file or directory.", _url.prettyUrl() ); - return errStr; - } - - if (!mainItem.isReadable()) - { - QString errStr = i18nc("%1=an URL", "Unable to read %1", _url.prettyUrl() ); - return errStr; - } - KUrl rootUrl = mainItem.url(); + // let me modify it.. + KUrl rootUrl = _url; // display "rekonq info" page QString infoFilePath = KStandardDirs::locate("data", "rekonq/htmls/rekonqinfo.html"); It works now. Please check again and close this bug. Regards. Thanks this is fixed in git commit 77311eaf0de9fd22f42df82adf69839091cc94c8 and git version 0.4.0-240-gec071ab thanks :D |