Bug 227929

Summary:	Notification icon tooltip has empty line with glow effect
Product:	[Unmaintained] plasma4	Reporter:	Karl Ove Hufthammer <karl>
Component:	notifications	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	asraniel, echidnaman, plasma-bugs
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Mandriva RPMs
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Screenshot showing the problem

Description Karl Ove Hufthammer 2010-02-21 13:17:42 UTC

Version:            (using KDE 4.4.0)
Installed from:    Mandriva RPMs

The tooltip for the notification icon in the system tray (the ‘i’ icon) has an additional (third) line of text. While this line is empty, it still creates a glow effect (around an invisible first character), which looks bad. See the attached screenshot.

I believe the problem occurs because of a trailing ‘<br>’ added to various strings at lines 194 to 221 in KDE/kdebase/workspace/plasma/generic/applets/notifications/core/extendertask.cpp

Comment 1 Karl Ove Hufthammer 2010-02-21 13:19:02 UTC

Created attachment 40979 [details]
Screenshot showing the problem

Comment 2 Jonathan Thomas 2010-02-24 02:11:18 UTC

I'm working on a patch to fix this issue: http://reviewboard.kde.org/r/3042/
(The <br>'s do have a purpose, they are just currently used in a "dumb" fashion.)

Once it's reviewed/OK'd I plan on doing a backport to the 4.4 branch. (Probably will miss 4.1.1, though)

Comment 3 Jonathan Thomas 2010-02-24 13:30:50 UTC

SVN commit 1095497 by jmthomas:

nstead of blindly inserting a <br> into the string, only do so if we have more stuff to add later. (That would justify inserting the <br>)
CCBUG: 227929


 M  +13 -4     extendertask.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1095497

Comment 4 Jonathan Thomas 2010-02-24 13:35:02 UTC

SVN commit 1095499 by jmthomas:

Backport 1095497 to the 4.4 branch
Instead of blindly inserting a <br> into the string, only do so if we have more
stuff to add later. (That would justify inserting the <br>)
BUG: 227929


 M  +9 -3      extendertask.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1095499