Bug 227912

Summary: strange dialog caption in playlist layout editor
Product: [Applications] amarok Reporter: Alexander Potashev <aspotashev>
Component: PlaylistAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal CC: nhn, teo
Priority: NOR    
Version: 2.3-GIT   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:

Description Alexander Potashev 2010-02-21 10:24:03 UTC 
Version:           2.2-GIT (using 4.4.00 (KDE 4.4.0), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.32

playlist/layouts/LayoutEditDialog.cpp:75:    setWindowTitle( i18n( "Configuration for" ) );

It could be for example "Configuration for %1", where %1 is the name of the item (Artist, Year, ...).
Comment 1 Myriam Schweingruber 2010-02-21 11:50:27 UTC 
That's something for Nikolaj
Comment 2 Nikolaj Hald Nielsen 2010-03-15 13:43:37 UTC 
commit a85e2f21305bc1bad1e328f92f14cd0a19e25d1c
Author: Nikolaj Hald Nielsen <nhn@kde.org>
Date:   Mon Mar 15 13:41:04 2010 +0100

    Fix bad window title for the details edit dialog in the playlist layout editor.
    
    ChangeLog++
    BUG: 227912

diff --git a/ChangeLog b/ChangeLog
index ac42cc1..7374e7b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -21,6 +21,8 @@ VERSION 2.3.1-Beta 1
        some MySQL versions. (BR 225052)
 
   BUGFIXES:
+     * Fixed bad window title for the details edit dialog in the playlist layout 
+       editor. (BR 227912)
      * Fixed wrong track getting dragged from The Playlist when sorting and/or
        filtering is active. (BR 226503)
      * Fixed visual indication for "Stop After This Track" not getting shown 
diff --git a/src/playlist/layouts/LayoutEditDialog.cpp b/src/playlist/layouts/LayoutEditDialog.cpp
index 8001fd4..e221f98 100644
--- a/src/playlist/layouts/LayoutEditDialog.cpp
+++ b/src/playlist/layouts/LayoutEditDialog.cpp
@@ -236,6 +236,8 @@ void LayoutEditDialog::setPeerWidth( bool peer )
 
 void LayoutEditDialog::setToken( TokenWithLayout *t )
 {
+    setWindowTitle( i18n( "Configuration for '%1'", t->name() ) );
+    
     apply();
     m_token = t;
     if ( m_token )