Bug 227516

Summary: changing sorting changes columns
Product: [Applications] kmail2 Reporter: Silver Salonen <silver.salonen>
Component: message listAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: bjoern, montel
Priority: NOR    
Version: 4.11.3   
Target Milestone: ---   
Platform: openSUSE   
OS: Unspecified   
Latest Commit: http://commits.kde.org/kdepim/5949d3215d1ab06b8733476c22f3094cecedad8f Version Fixed In: 4.11.4
Sentry Crash Report:

Description Silver Salonen 2010-02-18 13:38:00 UTC 
Version:           1.13.0 (using KDE 4.4.0)
Installed from:    openSUSE RPMs

1) Click somewhere on message list headers
2) Select Sorting -> By Date/Time ...

When I switch between any sorting, displayed columns are affected too. I have manually selected both "Sender" and "Receiver". On some sorting orders "Sender/Receiver" is enabled. This appears to be quite random - it is definitely not what I've chosen on this sorting order before, so it isn't it like remembering profiles. In addition to it, columns' width is affected and changed too.
Comment 1 Silver Salonen 2012-01-31 10:56:25 UTC 
Still happens with kmail2 (4.8.0).
Comment 2 Silver Salonen 2013-04-19 07:43:40 UTC 
Still happens with KMail 4.10.2
Comment 3 Silver Salonen 2013-06-17 07:35:32 UTC 
Still happens in 4.10.4.
Comment 4 Silver Salonen 2013-11-07 09:03:01 UTC 
Still happens in 4.11.3.
Comment 5 Laurent Montel 2013-11-07 09:25:32 UTC 
Ok will look at soon.
Comment 6 Ingo Klöcker 2013-11-16 15:57:45 UTC 
Git commit 5949d3215d1ab06b8733476c22f3094cecedad8f by Ingo Klöcker.
Committed on 15/11/2013 at 22:42.
Pushed by kloecker into branch 'KDE/4.11'.

Use dedicated slots for handling exactly the actions they should handle

Previously, all actions in the header context menu were handled by the
same method slotHeaderContextMenuTriggered(), even actions in submenus
which was clearly not intended. For example, selecting sorting
By Date/Time of Most Recent in Subtree in the Sorting submenu did also
enable the Sender column (because the action for showing/hiding the
Sender column had the same index set as user data as the action for
sorting By Date/Time of Most Recent in Subtree). Usage of dedicated
slots attached to the actions' signals instead of a single slot
attached to the menu's triggered() signal (which is also emitted for
actions in submenus) fixes this.
FIXED-IN: 4.11.4
REVIEW: 113901

M  +44   -45   messagelist/core/view.cpp
M  +17   -3    messagelist/core/view.h

http://commits.kde.org/kdepim/5949d3215d1ab06b8733476c22f3094cecedad8f