| Summary: | Various "Saved Playlists" incorrect right-click pop-up actions. | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Pierre Dumuid <pmdumuid> |
| Component: | Playlists/Saved Playlists | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | bart.cerneels |
| Priority: | NOR | ||
| Version: | 2.3-GIT | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
Hm, didn't Bart fix that yesterday? Fixed yesterday. I did not bother to check all the claims in the bug report nor read it all, please report each one separate if they persist. *** This bug has been marked as a duplicate of bug 226954 *** OK, I've gone through and verified all the above, and it seems to be working. I actually tested after it was said on IRC that things were fixed (c70953630c37a252) but it seems there must have been fixes that followed this. One other bug but I'll file a report when i get around to it. (basically, right clicking an "internal database" TRACK in a PLAYLIST says 'Remove from "<PrettyDateNow>"' rather than the actual name of the PLAYLIST. Pierre (In reply to comment #3) > One other bug but I'll file a report when i get around to it. (basically, right > clicking an "internal database" TRACK in a PLAYLIST says 'Remove from > "<PrettyDateNow>"' rather than the actual name of the PLAYLIST. > > Pierre That is a real bug and I just confirmed it. If you want to keep track to know when it's solved go ahead and create a bug report. commit 57b0ce4931d441c0e55b2fafb1721d874e3f3bf5 Author: Bart Cerneels <bart.cerneels@kde.org> Date: Tue Feb 16 15:06:30 2010 +0100 Fix the remove-action text. Caching the QAction does have the concequence of having to change the text when reused. I'm reusing a translated string from services/ampache/AmpacheConfigWidget.ui:98 This can be changed to something indicating multiple playlists if it turns out this is not clear enough. CCBUG:227112 diff --git a/src/playlistmanager/file/PlaylistFileProvider.cpp b/src/playlistmanager/file/PlaylistFileProvider.cpp index dd91186..a3ccc7d 100644 --- a/src/playlistmanager/file/PlaylistFileProvider.cpp +++ b/src/playlistmanager/file/PlaylistFileProvider.cpp @@ -131,6 +131,12 @@ PlaylistFileProvider::trackActions( Meta::PlaylistPtr playlist, int trackIndex ) m_removeTrackAction->setProperty( "popupdropper_svg_id", "delete" ); connect( m_removeTrackAction, SIGNAL( triggered() ), SLOT( slotRemove() ) ); } + else + { + m_removeTrackAction->setText( i18nc( "Remove a track from a saved playlist", + "Remove From \"%1\"" ).arg( playlist->name() ) ); + } + //Add the playlist/track combination to a QMultiMap that is stored in the action. //In the slot we use this data to remove that track from the playlist. PlaylistTrackMap playlistMap = m_removeTrackAction->data().value<PlaylistTrackMap>(); @@ -144,6 +150,9 @@ PlaylistFileProvider::trackActions( Meta::PlaylistPtr playlist, int trackIndex ) } m_removeTrackAction->setData( QVariant::fromValue( playlistMap ) ); + if( playlistMap.keys().count() > 1 ) + m_removeTrackAction->setText( i18n( "Remove" ) ); + actions << m_removeTrackAction; return actions; |
Version: 2.2-GIT (using KDE 4.3.5) OS: Linux Installed from: Gentoo Packages When navigating to "Media Sources" -> "Playlist" -> "Saved Playlists" PROBLEM 1: Incorrect right-click pop-up actions for HEADERs 1. Under the un-merged view: 2. Right clicking either header ("internal database" or "Playlist files on Disk") brings up a pop-up menu containing: .Add to playlist .Replace Playlist .Remove from "???.xspf" None of these actions work, and the last one is essentially saying "Remove Parent from child" where the header is a container for the children. PROBLEM 2: Incorrect right-click pop-up actions for PLAYLISTs A) Incorrect right-click pop-up entry in Merged View. When selecting Merged-view, and right clicking a playlist, the popup-shows an option to 'Remove from "<playlistName>"', but this action should be related to files not the actual playlist. Strangely again, the actual <playlistName> that shows up isn't specifically the one clicked! PROBLEM 2: Incorrect right-click pop-up actions for PLAYLIST TRACKSs When right-clicking a track in a playlist, it shows a pop-up menu for the entire playlist: . Add to playlist . Replace playlist . Rename . Delete In actual fact, all the actions seem to work correctly for the playlist, however "Add to playlist" should adds the whole playlist rather than the single file. Also, the action 'Remove from "<playlistName>"' isn't present, (Which appeared incorrectly for the PLAYLIST above) Also, it might be nicer to say "Add to Main Playlist" or play que to distinguish it from the "saved playlist". If the pop-up is to retain options for the whole playlist, it might be nice to have a seperator in the pop-up actions menu between track ops, and playlist ops. PROBLEM 4: Playlist popup adds wrong files. In Un-Merged view: When creating 4 playlists: 1. database1 2. database2 3. files1 4. files2 Right clicking playlist items and selecting either "Add to playlist" or "Replace Playlist" the playlist added to the Main playlist is not the same as the one selected. (hard to determine exact relationship as to which is loaded. In merged view: Seems right clicking and choosing either "Add to playlist" or "Replace Playlist" doesn't add any files? PROBLEM 5: Crashes In testing out the right-clicking, after a fair few right-clicks, I sometimes came across complete program crashes.