| Summary: | Picture of the day does not work | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Médéric Boquien <mboquien> |
| Component: | widget-frame | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alex_monika, annma, etienne.rebetez, magnus.bergmark, mirza.dervisevic |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Patch that makes potd work again.
Picture of the Day Patch |
||
|
Description
Médéric Boquien
2010-02-11 01:06:17 UTC
I can confim this. I found the source oft the setting bug. The Frame::stopPotd() is caled befor the setting is saved. In that function the "picture of the day" setting is removed. But the image will still not load... not working too Not working for me too :( Created attachment 42517 [details] Patch that makes potd work again. Two little things where wrong. - The potd Setting was not handlet correctly. (See Comment 1) - The datahash from the dataengine was always taken form the first position, where it obviusly not was. When it is adressed with the name, it works. Some data engine sources dont't seem to work anymore, but that's an other story. Created attachment 42548 [details]
Picture of the Day Patch
Didn't test it with a fresh picture frame...
The default text is now removed when a potd is loaded. I had to add a setMessage function in the picture class.
Sorry for my spam :/
SVN commit 1112069 by annma: Patch from Etienne, thanks a lot! :-) CCBUG=226230 M +1 -1 frame.cpp M +5 -0 picture.cpp M +1 -0 picture.h M +4 -3 slideshow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1112069 SVN commit 1112110 by annma: fix Picture of the Day display, thanks to Etienne! BUG=226230 M +1 -1 frame.cpp M +5 -0 picture.cpp M +1 -0 picture.h M +3 -2 slideshow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1112110 (In reply to comment #6) > SVN commit 1112069 by annma: > [...] > WebSVN link: http://websvn.kde.org/?view=rev&revision=1112069 Sorry to nitpick, but there's a spelling error in the diff for slideshow.cpp: "No Picture fot this Provider." Note "fot" instead of "for". It's still present in trunk as of this posting. Thanks. Yes, i never see typos. But, it was alredy corrected by annma. It says "No Picture from this Provider" which sounds good to me. (In reply to comment #9) > Thanks. Yes, i never see typos. > But, it was alredy corrected by annma. > It says "No Picture from this Provider" which sounds good to me. Maybe I misread it, but to me it looked like the correct spelling was in the 4.4 branch only, while the improperly spelt one was in trunk. Maybe I'm not understanding the repo structure here, but wouldn't that mean that the spelling error will be reintroduced in 4.5 and above? Magnus, what is your revision number for trunk?
For me rev 1123638 I have
m_picture->setMessage(i18n("No Picture from this Provider."));
line 203 slideshow.cpp in trunk
Find out with 'svn info' in your kdeplasma-addons trunk source please.
Also in the same dir please do:
grep -ri 'fot this ' ./
(In reply to comment #11) > Magnus, what is your revision number for trunk? Oh, I don't have it checked out or anything. I just looked at the above websvn link. One of them were for trunk and the other for branch 4.4, and the spelling error were only present in the trunk one. > For me rev 1123638 I have > m_picture->setMessage(i18n("No Picture from this Provider.")); > line 203 slideshow.cpp in trunk Then I trust that is correct. :-) Actually looking at websvn would have told you http://websvn.kde.org/trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp?r1=1112069&r2=1112105 (In reply to comment #13) > Actually looking at websvn would have told you > http://websvn.kde.org/trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp?r1=1112069&r2=1112105 I guess so. That diff was not linked to from here, and I'm just a user trying to help. |