| Summary: | Amarok crashes when I drag a mp3 file from Dolphin and drop it into the playlist | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Alexander <vo.zaeb> |
| Component: | Playlist | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | adrian.ioan.cozma, alex.merry, aureo.fetter, FreddyTheCat, grimm, hahol13, javier.conti, kde, kfunk, kristjan.ugrin, krzysztof.dzida, nhn, pablo.diogenes, PingusPepan, rasi, RobRoby, rodrialdecoa, roman.karlstetter, russianneuromancer, stefe68, teo, vkrevs, xbonio, xenomorph, zonken |
| Priority: | NOR | ||
| Version: | 2.3-GIT | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 2.3.0 | |
| Sentry Crash Report: | |||
| Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi New crash information added by DrKonqi New crash information added by DrKonqi |
||
|
Description
Alexander
2010-02-10 18:21:59 UTC
And you do use a build of today, don't you? Adapting title *** Bug 226336 has been marked as a duplicate of this bug. *** > And you do use a build of today, don't you?
Yep, and today build crashes too :)
*** Bug 226841 has been marked as a duplicate of this bug. *** Confirmed by duplicate *** Bug 226922 has been marked as a duplicate of this bug. *** Created attachment 40796 [details]
New crash information added by DrKonqi
Can reproduce. Also KDE SC 4.4 with amarok 2.2-git. This in on arch linux using kdemod.
Created attachment 40820 [details]
New crash information added by DrKonqi
In my case, I drag from the Amarok colleciton itself, into the playlist.
Created attachment 40860 [details]
New crash information added by DrKonqi
I can also confirm this. Dragging files from dolphin to amarok causes crash.
*** Bug 227283 has been marked as a duplicate of this bug. *** *** Bug 227286 has been marked as a duplicate of this bug. *** *** Bug 227441 has been marked as a duplicate of this bug. *** commit b1377ce5f642b3440e6485988d991eeeee98f0e5 Author: Kevin Funk <krf@electrostorm.net> Date: Thu Feb 18 16:56:19 2010 +0100 Fix crash when dragging files into Amarok. BUG: 226167 diff --git a/ChangeLog b/ChangeLog index 2742f2d..4f89efa 100644 --- a/ChangeLog +++ b/ChangeLog @@ -14,6 +14,8 @@ VERSION 2.3 last check. BUGFIXES: + * Fixed a bug when trying to drag files from some app into Amarok. + (BR 226167) * Fixed a bug in podcast parsing that broke all feeds that do not include a guid and possible overwrited data from other podcasts. Introduced in 2.3 beta. (BR 227515) diff --git a/src/playlist/view/listview/PrettyListView.cpp b/src/playlist/view/listview/PrettyListView.cpp index ab2fa9f..f36b3a1 100644 --- a/src/playlist/view/listview/PrettyListView.cpp +++ b/src/playlist/view/listview/PrettyListView.cpp @@ -553,6 +553,10 @@ Playlist::PrettyListView::startDrag( Qt::DropActions supportedActions ) { DEBUG_BLOCK + QModelIndexList indices = selectedIndexes(); + if( indices.isEmpty() ) + return; // no items selected in the view, abort. See bug 226167 + //Waah? when a parent item is dragged, startDrag is called a bunch of times static bool ongoingDrags = false; if( ongoingDrags ) @@ -564,15 +568,12 @@ Playlist::PrettyListView::startDrag( Qt::DropActions supportedActions ) if( m_pd && m_pd->isHidden() ) { - m_pd->setSvgRenderer( The::svgHandler()->getRenderer( "amarok/images/pud_items.svg" ) ); qDebug() << "svgHandler SVG renderer is " << (QObject*)(The::svgHandler()->getRenderer( "amarok/images/pud_items.svg" )); qDebug() << "m_pd SVG renderer is " << (QObject*)(m_pd->svgRenderer()); qDebug() << "does play exist in renderer? " << ( The::svgHandler()->getRenderer( "amarok/images/pud_items.svg" )->elementExists( "load" ) ); - QModelIndexList indices = selectedIndexes(); QList<QAction*> actions = actionsFor( this, &indices.first(), true ); - foreach( QAction * action, actions ) m_pd->addItem( The::popupDropperFactory()->createItem( action ), true ); *** Bug 228263 has been marked as a duplicate of this bug. *** *** Bug 228257 has been marked as a duplicate of this bug. *** *** Bug 228602 has been marked as a duplicate of this bug. *** *** Bug 228610 has been marked as a duplicate of this bug. *** *** Bug 228938 has been marked as a duplicate of this bug. *** *** Bug 229027 has been marked as a duplicate of this bug. *** Created attachment 41331 [details]
New crash information added by DrKonqi
Dragged folder from dolphin to amarok's "drop area". Folder was located in mounted NTFS partition.
(In reply to comment #21) > Created an attachment (id=41331) [details] > New crash information added by DrKonqi > > Dragged folder from dolphin to amarok's "drop area". Folder was located in > mounted NTFS partition. You have seen that this is already fixed in the git version since February 18th, didn't you? This was after the 2.2.90 release, so unless you are using the git version there is not much use to comment on this. *** Bug 229707 has been marked as a duplicate of this bug. *** *** Bug 230205 has been marked as a duplicate of this bug. *** *** Bug 230269 has been marked as a duplicate of this bug. *** *** Bug 230255 has been marked as a duplicate of this bug. *** *** Bug 230463 has been marked as a duplicate of this bug. *** *** Bug 237563 has been marked as a duplicate of this bug. *** *** Bug 244840 has been marked as a duplicate of this bug. *** |