| Summary: | don't "reload" document when file has been deleted | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | uetsah <uetsah> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | andrechalella, ivo |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
uetsah
2010-02-08 13:09:32 UTC
It seems to me that you could disable the watch file option and be happy. Of course the "better" solution would be showing a message saying the file was removed from the file system and not "reloading" it until the file gets recreated. But i don't have time to implement that. > It seems to me that you could disable the watch file option and be happy. That's what I've done, but I'm not really happy with it, as I find that feature useful in other circumstances... (When files actually do *change*, not get deleted...) > Of course the "better" solution would be showing a message saying the file was > removed from the file system and not "reloading" it until the file gets > recreated. Probably just adding [*] or [deleted] to the window title would suffice. Okular already has enough redundant message boxes that can get in your way... > But i don't have time to implement that. I understand that... I still hope that someone might implement it in the future though. The only occasion when Okular reloads the document is when the document is changed, but not when it is deleted. What you see is mostly an effect of the recent hiccups in the KDE file watching service, which most probably is sending (also or only) a "deleted" notification. Please wait for KDE 4.4.1, and test back when you have such version. *** Bug 228196 has been marked as a duplicate of this bug. *** I've just built the KDE 4.4 branch and re-tested this. Both - taking away read permissions from an open file - doing open with on firefox, then closing firefox still make okular reload to an empty window, so I'd say this is unrelated to the KDE file watching problems (or they are still there). SVN commit 1095777 by dfaure: Fix bug found by discussing with pinotree about #225907: deleted() wasn't emitted anymore. Added unittest for that, and checked that dirty() isn't emitted (due to my other recent changes to KDirWatch), so at least deletion of the watched file is handled correctly now. Fixed for: 4.4.1 CCBUG: 225907 M +2 -2 kio/kdirwatch.cpp M +21 -0 tests/kdirwatch_unittest.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1095777 > - I click a PDF link in a web browser uetsah, is firefox the said "web browser", by chance? If so, this is another case for the fixed bug #234139. I can confirm that this bug applies to Firefox, not occuring when opening a file in Okular and manually deleting it behind the scenes. So I guess that's a step in order to categorize this as a duplicate of #234139. "uetsah, is firefox the said "web browser", by chance? If so, this is another case for the fixed bug #234139." Yes, but I thought it also happened with console delete/rename back when I reported the bug (but I could also be mistaken). In any case, it seems to be indeed fixed now for me (using KDE 4.5.1). Both the Firefox case, and the rename/delete case work fine now - the document stays open in Okular. Thanks, btw... :-) *** This bug has been marked as a duplicate of bug 234139 *** |