Summary: | Umbrello segmentation fault crash modifying attribute | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Stefano <paperclip> |
Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | kde |
Priority: | NOR | ||
Version: | 2.3.2 | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/umbrello/923ba58b365ea1900fb13c041a3c9552eb5c2759 | Version Fixed In: | 4.11.5 |
Sentry Crash Report: | |||
Attachments: | XMI reproducing the described issue |
Description
Stefano
2010-02-02 18:27:04 UTC
Umbrello freshly installed from Synaptic. Created attachment 84342 [details]
XMI reproducing the described issue
Confirmed, the problem exists in all releases of 4.11 and newer.
Steps to reproduce:
1. Add two class widgets on a diagram
2. Associate one with the other
3. Open properties dialog of class
4. Add new attribute -> OK
*crash*
Git commit ca2ac6f54ac3030589836eb284bd21dd16d6f3a7 by Joris Steyn. Committed on 30/12/2013 at 11:24. Pushed by jorissteyn into branch 'KDE/4.11'. Fix crash when adding attribute There was an obscure crash in the code generator triggered by Import_Utils. It tried to add the attribute to the logical view, explicitly setting ot_Attribute prevents this behaviour. M +1 -1 umbrello/dialogs/umlattributedialog.cpp http://commits.kde.org/umbrello/ca2ac6f54ac3030589836eb284bd21dd16d6f3a7 Git commit cbddac2fd9cbaa8fec4daeddd4a806aad4ca4246 by Joris Steyn. Committed on 30/12/2013 at 11:24. Pushed by jorissteyn into branch 'KDE/4.12'. Fix crash when adding attribute There was an obscure crash in the code generator triggered by Import_Utils. It tried to add the attribute to the logical view, explicitly setting ot_Attribute prevents this behaviour. M +1 -1 umbrello/dialogs/umlattributedialog.cpp http://commits.kde.org/umbrello/cbddac2fd9cbaa8fec4daeddd4a806aad4ca4246 Git commit 61149e5f6a8365ed71a6eda793cb91ada36687b4 by Joris Steyn. Committed on 30/12/2013 at 11:24. Pushed by jorissteyn into branch 'master'. Fix crash when adding attribute There was an obscure crash in the code generator triggered by Import_Utils. It tried to add the attribute to the logical view, explicitly setting ot_Attribute prevents this behaviour. M +1 -1 umbrello/dialogs/umlattributedialog.cpp http://commits.kde.org/umbrello/61149e5f6a8365ed71a6eda793cb91ada36687b4 Note about steps-to-reproduce: attribute type must be empty, language must be c++ or java and new code generator must be turned on. Previous fix was bogus, a better one is coming up and will be released in 4.11.5. Git commit 1e6e3df30e823ed76b176f03ae931c2394b10995 by Joris Steyn. Committed on 01/01/2014 at 21:57. Pushed by jorissteyn into branch 'KDE/4.11'. Better fix for attribute creation crash Previous fix was faulty. The problem occurs when an object is looked up with an empty name. Instead of not finding an object, umldoc can return an arbitrary association object instead, resulting in problems in Import_Utils. This change prevents calling Import_Utils with an empty typeName, so when an attribute is created without specifying a type, the default behaviour of creating a new class with Object_Factory is triggered - which handles this case well. M +13 -2 umbrello/dialogs/umlattributedialog.cpp http://commits.kde.org/umbrello/1e6e3df30e823ed76b176f03ae931c2394b10995 Git commit e84b97d0ebc3b0c82a0688f9daf6365bc22ae405 by Joris Steyn. Committed on 01/01/2014 at 21:57. Pushed by jorissteyn into branch 'KDE/4.12'. Better fix for attribute creation crash Previous fix was faulty. The problem occurs when an object is looked up with an empty name. Instead of not finding an object, umldoc can return an arbitrary association object instead, resulting in problems in Import_Utils. This change prevents calling Import_Utils with an empty typeName, so when an attribute is created without specifying a type, the default behaviour of creating a new class with Object_Factory is triggered - which handles this case well. M +13 -2 umbrello/dialogs/umlattributedialog.cpp http://commits.kde.org/umbrello/e84b97d0ebc3b0c82a0688f9daf6365bc22ae405 Git commit 923ba58b365ea1900fb13c041a3c9552eb5c2759 by Joris Steyn. Committed on 01/01/2014 at 21:57. Pushed by jorissteyn into branch 'master'. Better fix for attribute creation crash Previous fix was faulty. The problem occurs when an object is looked up with an empty name. Instead of not finding an object, umldoc can return an arbitrary association object instead, resulting in problems in Import_Utils. This change prevents calling Import_Utils with an empty typeName, so when an attribute is created without specifying a type, the default behaviour of creating a new class with Object_Factory is triggered - which handles this case well. M +13 -2 umbrello/dialogs/umlattributedialog.cpp http://commits.kde.org/umbrello/923ba58b365ea1900fb13c041a3c9552eb5c2759 |