Bug 224814

Summary: External getdata library for dirfile datasource not working correctly
Product: [Applications] kst Reporter: Andrew Walker <arwalker>
Component: generalAssignee: kst
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.8.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: plot of data with external getdata
plot of data with internal getdata

Description Andrew Walker 2010-01-29 20:55:40 UTC
Version:           1.8.0 (using KDE 4.3.4)
OS:                Linux
Installed from:    Compiled From Sources

PROBLEM:

The dirfile datasource will use, if present, the getdata library.
If not present the dirfile datasource will fall back to an internal implementation of the getdata functionality.
However, the results of the two (for at least 's', UINT16, data types) is inconsistent.

STEPS TO REPRODUCE:

Build kst with the getdata library (at least 0.4.2) installed and plot 's' type data with values increasing from 0 to 65535 (expressed in terms of unsigned values).

Build kst without the getdata library installed and plot 's' type data with values increasing from 0 to 65535 (expressed in terms of unsigned values).

EXPECTED RESULTS:

The two plots should be identical.

ACTUAL RESULTS:

The two plots are different. For the external version of getdata the values increase from 0 to 65535, while for the internal version they show the expected jump to negative values.
Comment 1 Andrew Walker 2010-01-29 20:58:18 UTC
Created attachment 40360 [details]
plot of data with external getdata
Comment 2 Andrew Walker 2010-01-29 20:58:47 UTC
Created attachment 40361 [details]
plot of data with internal getdata
Comment 3 Andrew Walker 2010-01-29 21:01:19 UTC
If the problem in getdata is fixed in the near future we could ensure that kst uses only the recently corrected version of the getdata library. 

Otherwise we could just remove the dependency on the getdata library entirely.
Comment 4 D. V. Wiebe 2010-01-29 21:44:48 UTC
Which version of GetData are you using?

I can reproduce this with kst-1.8.0 + getdata-0.4.2, but it works properly here with kst-1.8.0 + getdata-0.6.0.  So, it looks like it's been fixed upstream already.
Comment 5 Andrew Walker 2010-01-29 21:54:07 UTC
I'm using getdata-0.5.0

I'll test things with getdata-0.6.0 and either upgrade the version requirement within kst, or disable the use of the external getdata for the next release of kst.
Comment 6 Andrew Walker 2010-01-29 22:36:21 UTC
SVN commit 1082170 by arwalker:

BUG:224814 ensure we're using getdata version 0.6.0 or newer as earlier versions do not work correctly with INT16 (s) data.

 M  +5 -3      CMakeLists.txt  
 M  +1 -1      src/datasources/dirfile/configure.in.in  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1082170