Bug 224136

Summary:	Show dialog with settings when saving image on Windows [patch]
Product:	[Applications] digikam	Reporter:	David Eriksson <meldavid>
Component:	ImageEditor-Core	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles
Priority:	NOR
Version:	1.1.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:	1.1.0
Attachments:	Patch implementing the dialog

Description David Eriksson 2010-01-25 09:55:22 UTC

Version:           1.1.0 (using 4.3.4 (KDE 4.3.4), compiled sources)
Compiler:          gcc.exe
OS:                Microsoft Windows (i686) release 5.1 (XP Professional)

When saving a image on Windows the FileSaveOptionsBox is not shown since the native Windows Save As-dialog is used. This patch puts the FileSaveOptionsBox in a dialog that is shown after the Save As-dialog on Windows. The behavior can be turned off via a setting.

Comment 1 David Eriksson 2010-01-25 09:56:28 UTC

Created attachment 40216 [details]
Patch implementing the dialog

Comment 2 caulier.gilles 2010-01-25 10:17:09 UTC

David,

Thanks to contrib. it's very appreciate...

Why to add a digiKam setup option to show or not "file save as settings" view in dialog. For me this must be always avaialble. I never see a photo application with a similar behavior.

Why not to use RExpanderBox widget to host "file save as settings" view. You can expand and collapse view and remember view state between session. Look there :

http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/widgets/common/rexpanderbox.h?revision=1048660&view=markup

For the rest of the patch, as coding style,, all is fine for me.

Gilles Caulier

Comment 3 David Eriksson 2010-01-25 10:44:56 UTC

Gilles,

I added the option since it changes the old behavior with only one dialog. Some people never changes the default values and some can get annoyed to have to press Ok twice.

The dialog only shows the settings for the current file type using the FileSaveOptionsBox so I don't see why a RExpanderBox is needed. No dialog is shown for file types without options.

David

Comment 4 caulier.gilles 2010-01-25 10:52:07 UTC

>I added the option since it changes the old behavior with only one dialog. Some
>people never changes the default values and some can get annoyed to have to
>press Ok twice.

Ok now i understand. This want mean that under windows, and windows only, this option is valid, because file saveas settings is displayed in a new dialog (as gimp does for exemple).

Under linux this is not the case, because file save as dialog provided by KDE can embbed settings as well. It simplify usability.

Gilles Caulier

Comment 5 caulier.gilles 2010-01-25 11:08:50 UTC

SVN commit 1079934 by cgilles:

apply patch #40216 from David Eriksson
BUGS: 224136


 M  +1 -0      CMakeLists.txt  
 M  +33 -3     utilities/imageeditor/editor/editorwindow.cpp  
 M  +32 -0     utilities/setup/setupiofiles.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1079934