Bug 223502

Still the same with Amarok 2.3.0.

Tested with Amarok 2.3.0.90: When the same comments are re-added by Amarok, they are also shown correctly afterwards.

Is this still valid for Amarok 2.3. or 2.3.2 beta?

Perhaps, this is actually an Amarok 1.4 issue; since I re-added all tags with newlines with Amarok 2.3.0.90, they are shown correctly. In the moment, I use Amarok 2.3.1.

I can't reproduce this with an older Amarok version, as Gentoo does not provide KDE 3 support anymore and I can't install Amarok 1.4.x (at least not with the official packages).

No problem, we don't track bugs from 1.4 anymore anyway, it's unmaintained since 2 years already. Closing as fixed.

I just managed to reproduce this bug with Amarok 2.3.1. I changed from embedded MySQL to an external MySQL server and the comments with newlines are gone again. Perhaps this is a database issue?

Could you please make sure it is not just a caching issue by the collection browser? Do a full rescan, then restart Amarok and check if that helps.

After a full rescan and a restart, nothing changes, the comments don't show up (and as before, only those comments which contain newlines).

Thank you for the feedback.

Hi,

Could you send me the file you are seeing this problem with so I can test?

mitchell
kde
org

Thanks!

I just sent you one example file.

commit 3329be723725c522512a4e3f17401ab3205a67da
Author: Jeff Mitchell <mitchell@kde.org>
Date:   Thu Sep 9 13:54:46 2010 -0400

    Remove stripping of nonprintable characters in the scanner. This causes problems with things like embedded comments and lyrics that have newlines or tabs. Keep the check for qchars that lack categorization.
    
    BUG: 223502

diff --git a/ChangeLog b/ChangeLog
index 4225d83..2acb016 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -12,6 +12,8 @@ VERSION 2.3.2
     * Use system date/time format for default name when saving user playlists.
 
   BUGFIXES:
+    * Comments embedded in files that contained newlines or tabs could be
+      skipped entirely. (BR 223502)
     * The equalizer dialog did not discard changes when clicking "Cancel".
       Patch by Anton Gritsay <anton@angri.ru>. (BR 242730)
     * The Last.fm service did not work without KWallet. (BR 235861)
diff --git a/utilities/collectionscanner/CollectionScanner.cpp b/utilities/collectionscanner/CollectionScanner.cpp
index cbe55a1..a9d6755 100644
--- a/utilities/collectionscanner/CollectionScanner.cpp
+++ b/utilities/collectionscanner/CollectionScanner.cpp
@@ -826,17 +826,17 @@ CollectionScanner::writeElement( const QString &name, const AttributeHash &attri
         // Because of this we skip attributes containing characters not belonging to any category.
         const QString data = escape( it.value() );
         const unsigned len = data.length();
-        bool nonPrint = false;
+        bool noCategory = false;
         for( unsigned i = 0; i < len; i++ )
         {
-            if( !data[i].isPrint() || ( data[i].category() == QChar::NoCategory ) )
+            if( data[i].category() == QChar::NoCategory )
             {
-                nonPrint = true;
+                noCategory = true;
                 break;
             }
         }
 
-        if( nonPrint )
+        if( noCategory )
             continue;
 
         element.setAttribute( it.key(), it.value() );