Bug 223451

Summary: Port recipients editor to Akonadi API
Product: [Applications] kmail2 Reporter: Thomas McGuire <mcguire>
Component: composerAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: unnamedrambler, vkrause, wstephenson
Priority: NOR Keywords: akonadi-ports-regression
Version: 1.99.0   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Bug Depends on:    
Bug Blocks: 223438    

Description Thomas McGuire 2010-01-19 20:25:07 UTC
The recipients editor needs to be ported away from the KResource API to the Akonadi API.
That includes the infamous addresseelineedit.

We can't really really on the KResource bridges for 4.5 anymore, the setup of those is flaky.
Comment 1 Thomas McGuire 2010-01-19 20:26:34 UTC
Also, the two LDAP dialogs in libkdepim and KAddressbook should be merged, which is somewhat related to this.
Comment 2 Casey Link 2010-03-26 18:51:33 UTC
SVN commit 1107753 by link:

initial commit to port recipients editor to Akonadi API. Implements the async ContactSearchJob API. Virtuoso doesn't allow partial matches with strings < 4 characters in length, so auto completion will not return a match until 4 characters have been typed. 
Note: this has been added along side the KResource code
CCBUG: 223451


 _M            . (directory)  
 M  +36 -0     addresseelineedit.cpp  
 M  +3 -0      addresseelineedit.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1107753
Comment 3 Casey Link 2010-03-27 19:55:14 UTC
SVN commit 1108075 by link:

Complete akonadi port of addresseelineedit. Removed KResource cruft, cleaned up my style, and, most importantly, contacts will now appear in the list under the heading of their akonadi collection. Weighting akonadi contacts still needs to be done, but I'm not sure how (is it even needed?).
BUG: 223451


 M  +78 -60    addresseelineedit.cpp  
 M  +5 -7      addresseelineedit.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1108075
Comment 4 Casey Link 2010-03-27 19:58:03 UTC
(In reply to comment #1)
> Also, the two LDAP dialogs in libkdepim and KAddressbook should be merged,
> which is somewhat related to this.

this was done by tobias, see r1107405
http://websvn.kde.org/?view=revision&revision=1107405
Comment 5 Thomas McGuire 2010-03-27 20:14:51 UTC
Reopening, the recipient editor of KMail is not yet ported, only the addresseelineedit.

The recipient editor can be found in the composer by clicking on the "Select..." button next to the To line.
Comment 6 Volker Krause 2010-05-09 15:30:30 UTC
Done by Tobias in revisions 1120100 - 1120158.
Comment 7 Will Stephenson 2010-08-15 17:49:12 UTC
Explaining comment#6 - not done for KDE 4.4, will be available when kdepim 4.5 is released.