Bug 222975

Summary: Wrong editorwindow zoom behaviour
Product: [Applications] digikam Reporter: Jens Mueller <tschenser>
Component: ImageEditor-CanvasAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In: 1.1.0
Sentry Crash Report:

Description Jens Mueller 2010-01-16 14:29:01 UTC 
Version:            (using KDE 4.3.4)
OS:                Linux
Installed from:    Ubuntu Packages

Steps to reproduce:
- open a image in editorwindow
- play with zoomin or zoomout button from toolbar
- select tool, for example sharpen

current behaviour (1.1 svn):
- opening the tool adjusts zoom settings of photo but does not update zoom value in toolbar

This comes with some usability question: Should tools change zoom settings when started or not?
Comment 1 caulier.gilles 2010-01-16 19:20:21 UTC 
I don't have checked indeep all zoom behaviors with new editor tool factoring review... 

but for me zoom from canvas must be set at the same value in tool.

Also, there is some restriction to zooming code due to little problem with preview mode. I must fix it too.

For details, look code there : 

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/widgets/imageregionwidget.cpp#140

Gilles Caulier
Comment 2 caulier.gilles 2010-01-20 12:20:39 UTC 
SVN commit 1077548 by cgilles:

Editor Tool Preview factoring : Important change here
- Now editor tool based on image region widget preview can be zommed to 100% all time. there is no zomming 
restriction based on image size to always fit contents to preview size.
- When user select a zommable editor tool, canvas zoom is applied to preview.
- All preview mode are available with image region widget tools based (NR, refocus, etc...)

Warnings: this commit do not finalize preview factoring and regressions tests need to be done again. 
I can see preview dysfunctions in some cases.

TODO : port progressively all editor tools based on image guide widget (not zommable) to image region widget (zommable) as WB, curves, levels, etc...

BUGS: 221987
BUGS: 163284
BUGS: 148072
BUGS: 222975
CCBUGS: 197316
CCBUGS: 148235
CCBUGS: 220567
CCBUGS: 196469
CCBUGS: 221988



 M  +5 -0      canvas/canvas.cpp  
 M  +1 -0      canvas/canvas.h  
 M  +7 -4      editor/editortooliface.cpp  
 M  +24 -54    widgets/imageregionwidget.cpp  
 M  +4 -7      widgets/imageregionwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1077548