Bug 222911

Summary:	No warning message when not entering a sound file in the Edit Reminder dialogue.
Product:	[Applications] korganizer	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	VERIFIED FIXED
Severity:	normal	CC:	montel
Priority:	NOR
Version First Reported In:	4.3
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Sabine Faure 2010-01-15 23:32:47 UTC

Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch Kontact and go to KOrg
- Click on the 'New Event' button and enter the details for a new event
- Check the reminder box, set the reminder time to 1 min and click on the 'Advanced...' button
- In the 'Edit Reminders' dialogue select the 'Sound' radio button
- A 'Sound file:' line edit appears and next to it as well as a floppy disk button so that the user can select a sound file.
- Click on 'Ok'

One minute before the event starts a pop up dialogue appears but since no sound file has been selected there is no sound reminder.

I think there should either be a default sound or at least a warning pop up message saying something like: 'The sound reminder will not be activated since you have not yet selected a sound file (.wav or .ogg). Would you like to do it now?'

Akonadi-ports Branch, Svn Rev 1075014

Comment 1 Laurent Montel 2010-01-21 19:34:48 UTC

SVN commit 1078195 by mlaurent:

Disable button when sound url is empty
CCBUGS: 222911


 M  +16 -1     koeditoralarms.cpp  
 M  +1 -1      koeditoralarms.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1078195

Comment 2 Laurent Montel 2010-01-21 19:37:10 UTC

Fixed in svn trunk. Disable ok/apply buttons until url is empty.

Comment 3 Sabine Faure 2010-01-22 18:36:10 UTC

This is corrected now.

The 'Ok' button is now inactive when the user selects the 'Sound' radio button and remains that way until an .ogg or .wav file has been selected.

However there is no warning message explaining why the 'Ok' button is inactive. It is up to the user to understand that he must enter a sound file.

Trunk, Svn Rev 1078580