Bug 221933

Summary: menu disbabled when F4 in digikam and e.g. sharpening was previously open
Product: [Applications] digikam Reporter: Bartek Pietrasiak <pietras.sp>
Component: Plugin-Editor-SharpenAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: tschenser
Priority: NOR    
Version: 1.1.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 1.1.0
Sentry Crash Report:

Description Bartek Pietrasiak 2010-01-09 16:05:37 UTC 
Version:           1.1.0 (rev.: 1072142) (using 4.3.3 (KDE 4.3.3), 4.3.3-4.fc11 Fedora)
Compiler:          gcc
OS:                Linux (i686) release 2.6.30.9-102.fc11.i686.PAE

menu disbabled when F4 in digikam while editor is open and e.g. sharpening was is open
Comment 1 caulier.gilles 2010-01-11 17:11:50 UTC 
Not all options are disabled... It's mandatory. You run an editor tool. You cannot play with another tool at the same time.

Gilles Caulier
Comment 2 Bartek Pietrasiak 2010-01-12 11:21:42 UTC 
Steps:
1. F4 in digikam
2. Sharpening in editor
3. Again F4 in digikam on the same file (seems to occurs only on the same file now) == editor reloads, sharpening is closed but menu disabled
Comment 3 Jens Mueller 2010-01-13 00:11:33 UTC 
I investigate a little bit time in this, hope that helps:

First ImageWindow::loadCurrentList is called. This function triggers a Qtimer http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp#594

Afterwards EditorToolIface::unloadTool is called, this enables all KActions http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editortooliface.cpp#121

Now ImageWindow::slotLoadCurrent from first Step is executed, this function call Canvas::load at http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/imagewindow.cpp#603

Canvas::load call EditorWindow::slotPrepareToLoad and this disables all KActions again at http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/editor/editorwindow.cpp#1431

Because the Image was already loaded, no finishLoad and enabling all actions take place.

Jens
Comment 4 Marcel Wiesweg 2010-01-21 21:36:40 UTC 
SVN commit 1078235 by mwiesweg:

When loading is skipped, because current image is identical, emit signals anyway
so that UI is toggled appropriately

BUG: 221933

 M  +2 -1      NEWS  
 M  +1 -1      utilities/imageeditor/canvas/canvas.cpp  
 M  +5 -0      utilities/imageeditor/canvas/dimginterface.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1078235