Bug 221922

Download only works with option "right mouse button" -> "download" but not with the option "copy to collection". This last option worked fine before!

Es sieht so aus, wie wenn ich überhaupt keine ogg-Dateien mehr zur Playlist hinzufügen könnte. Allerdings nur aus Media Sources -> Dateien. Aus der Sammlung funkt es!

(In reply to comment #2)
> Es sieht so aus, wie wenn ich überhaupt keine ogg-Dateien mehr zur Playlist
> hinzufügen könnte. Allerdings nur aus Media Sources -> Dateien. Aus der
> Sammlung funkt es!

English, please...
What does your comment have to do with that bug report? Please only one item per report, and again, please use the forum or the IRC channel for support questions. If something worked one day and doesn't the next then the probability is high that something is wrong with your settings.

Created attachment 39724 [details]
Ressources that Amarok uses

Sorry, this should have been in English!

1. This works:

ogg files out of collections

2. This does not work:

a. ogg files out of the file menu
b. ogg files out of Jamendo

In case of internet files kde some times will be blocked completely.

> What does your comment have to do with that bug report? Please only one
> item per report, and again, please use the forum or the IRC channel for
> support questions. If something worked one day and doesn't the next then
> the probability is high that something is wrong with your settings.

A, I can see you wrote an answer in parallel. 

1. Myriam, if you cannot see what the one thing has to do with the other... Jamendo normally offers ogg files, correct? Ogg files produce the errors. 

2. Why should my settings have something to do with this? I mean for should you always could imagine this or even suspect me of having done something awful. But you know I simple use this piece of software. 

3. Did I post any question here? So what is support of all points I added?

It is not an Amarok bug apparently, but a problem with Jamendo:

http://www.jamendo.com/en/forums/discussion/8704/torrent-tracker-for-ogg/#Item_0

Apparently, Amarok doesn't play anymore when trying to play an ogg stream, which indicates that the Jamendo stream causes a problem with Phonon.
This is most likela a bug with Jamendo, but reassigning to Phonon nonetheless for more security.

*** Bug 222376 has been marked as a duplicate of this bug. ***

*** Bug 222732 has been marked as a duplicate of this bug. ***

It seems that by the moment jamendo is unable to serve ogg streams ( http://www.jamendo.com/en/forums/discussion/9705/internal-server-error-for-streams/ ), but it can do through mp3 simply removing "&streamencoding=ogg2" from the song stream url. Maybe it could be changed in amarok jamendo service?

*** This bug has been confirmed by popular vote. ***

Is there any way to remove "&streamencoding=ogg2" from all stream urls for jamendo automatically when adding to playlist as a temporary solution?

commit f9eefc21f8cfc5b8810df18790c2537c92bc0825
Author: Nikolaj Hald Nielsen <nhn@kde.org>
Date:   Wed Feb 24 10:24:51 2010 +0100

    Temporary workaround for broken Jamendo url redirection
    
    BUG: 221922

diff --git a/src/services/jamendo/JamendoXmlParser.cpp b/src/services/jamendo/JamendoXmlParser.cpp
index 1a928dd..cb3f5a6 100644
--- a/src/services/jamendo/JamendoXmlParser.cpp
+++ b/src/services/jamendo/JamendoXmlParser.cpp
@@ -385,7 +385,10 @@ JamendoXmlParser::readTrack()
                 genre = m_id3GenreHash.value( m_reader.readElementText().toInt() );
         }
     }
-    static const QString previewUrl = "http://api.jamendo.com/get2/stream/track/redirect/?id=%1&streamencoding=ogg2";
+
+    //FIXME: temp workaround for bug 221922. Remove if Jamendo fixes their redirects
+    //static const QString previewUrl = "http://api.jamendo.com/get2/stream/track/redirect/?id=%1&streamencoding=ogg2";
+    static const QString previewUrl = "http://api.jamendo.com/get2/stream/track/redirect/?id=%1";
 
     JamendoTrack currentTrack( name );
     currentTrack.setId( id.toInt() );

(In reply to comment #12)
> commit f9eefc21f8cfc5b8810df18790c2537c92bc0825
> Author: Nikolaj Hald Nielsen <nhn@kde.org>
> Date:   Wed Feb 24 10:24:51 2010 +0100
> 
>     Temporary workaround for broken Jamendo url redirection
> 
>     BUG: 221922
> 
> diff --git a/src/services/jamendo/JamendoXmlParser.cpp
> b/src/services/jamendo/JamendoXmlParser.cpp
> index 1a928dd..cb3f5a6 100644
> --- a/src/services/jamendo/JamendoXmlParser.cpp
> +++ b/src/services/jamendo/JamendoXmlParser.cpp
> @@ -385,7 +385,10 @@ JamendoXmlParser::readTrack()
>                  genre = m_id3GenreHash.value(
> m_reader.readElementText().toInt() );
>          }
>      }
> -    static const QString previewUrl =
> "http://api.jamendo.com/get2/stream/track/redirect/?id=%1&streamencoding=ogg2";
> +
> +    //FIXME: temp workaround for bug 221922. Remove if Jamendo fixes their
> redirects
> +    //static const QString previewUrl =
> "http://api.jamendo.com/get2/stream/track/redirect/?id=%1&streamencoding=ogg2";
> +    static const QString previewUrl =
> "http://api.jamendo.com/get2/stream/track/redirect/?id=%1";
> 
>      JamendoTrack currentTrack( name );
>      currentTrack.setId( id.toInt() );

Hey  Nikolaj,

can you add a description what your workaround is about? In Germany we say: "ich verstehe nur Bahnhof!" I think there should be a description like that:

1. What we (the developers) did

2. What you (the user) can do

3. The release that fixes the problem

Regards, Martin

Martin,

Will you please refrain from reopening fixed bugs in this way? The only exception is if you can document that it is indeed not fixed.

This bug was automatically closed by our commit filter which adds the commit message of the change that resolved the issue. This commit simply fixes the issue of Jamendo's ogg streams not working but using the mp3 streams instead. A user simply needs to update the Jamendo database. As always, this will be in the next release, in this case 2.3

(In reply to comment #14)
> Martin,
> 
> Will you please refrain from reopening fixed bugs in this way? The only
> exception is if you can document that it is indeed not fixed.
> 
> This bug was automatically closed by our commit filter which adds the commit
> message of the change that resolved the issue. This commit simply fixes the
> issue of Jamendo's ogg streams not working but using the mp3 streams instead. A
> user simply needs to update the Jamendo database. As always, this will be in
> the next release, in this case 2.3

Nikolaj,

to be honest I do not care a lot if this is the way you suppose that we as users act. The process of bug fixing should be designed in a way that the users out here as well understand what happens.

The process of automatic closure may be well designed for you, working on these items but it is absolutely not for us users out here.

Sorry for that and thank you for your help! :-)

Martin