Summary: | powerdevil always suspends twice | ||
---|---|---|---|
Product: | [Frameworks and Libraries] solid | Reporter: | S. Burmeister <sven.burmeister> |
Component: | powermanagement-daemon | Assignee: | Dario Freddi <drf> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | chgonzalezg, ctibor.brancik, debfx-kde, EagleScreen, hallbw, jablan, jithin1987, kde, long, mail, rdieter, spatz, summelsam, tiago.miguel43 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Patch to fix double suspend bug |
Description
S. Burmeister
2010-01-07 13:11:34 UTC
I can confirm this using 4.3.90 compiled from gentoo kde overlay. This bug is still present in KDE 4.4.0 using OpenSuse RPM's. Autosuspend (both: to disk or to RAM) is always done twice, for instance when battery is critical low and KDE suspends, or when laptop has been X minutes in inactivity. Still have the bug on 4.4 final (arch linux) no matter how long the laptop is in suspend i always have to wake him up a second time. since i only can wake him by using the power button i dont know if this only happens then and/or also when waking the laptop up by opening the lid. (In reply to comment #3) > Still have the bug on 4.4 final (arch linux) > > no matter how long the laptop is in suspend i always have to wake him up a > second time. > > since i only can wake him by using the power button i dont know if this only > happens then and/or also when waking the laptop up by opening the lid. (Hardware: Samsung NC10) Existriert problem with KDE 4.4.1 too. First time suspend to RAM before notification begins to count (30 sec). After resume, after 30 sec counter sent computer back to suspend. (Opensuse 11.2, Aspire 5100) I can, also, confirm this bug on OpenSUSE 11.2, running KDE 4.4.1. After a certain amount of time my laptop suspends. When I wake it up, it suspends again and I have to wake it up again. This does not happen if I manually suspend it. *** This bug has been confirmed by popular vote. *** Confirm bug on Arch Linux 32-bit with KDE 4.4-3 This bug is terrible for laptop users, who usually uses suspend functionalities. I don't understand why this bug hasn't a higher priority. After two bugfix revisions after KDE 4.4.0 was released, this bug is still present, we are already going to 4.4.3 and I do not see any activity or interest in fixing this bug by developers. I know this is Free Software and this is made by volunteers, so we cannot "demand", but this bug is really important to fix. *** Bug 225010 has been marked as a duplicate of this bug. *** Created attachment 42725 [details]
Patch to fix double suspend bug
The bug is in PowerDevilDaemon::emitNotification()
It calls the slot (in this case suspendToRam()) immediately and after the waitBeforeSuspendingTime.
So PowerDevil shows the suspend notification and suspends right away.
After waking up PowerDevil suspends again after the waitBeforeSuspendingTime.
The solution is to not call the slot immediately as it also breaks the waiting before suspension/shutdown.
SVN commit 1115238 by fgeyer: Fix PowerDevil always suspending the system twice and not waiting the configured time before suspending/shutting down. BUG: 221637 M +0 -4 PowerDevilDaemon.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1115238 SVN commit 1115243 by fgeyer: Backport r1115238. Fix PowerDevil always suspending the system twice and not waiting the configured time before suspending/shutting down. CCBUG: 221637 M +0 -4 PowerDevilDaemon.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1115243 Suffering this same bug in 4.8.2. Should I open a new one? This one is quite old. |