| Summary: | RW2 images are not rotated anymore | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | S. Burmeister <sven.burmeister> |
| Component: | Thumbs-RAW | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, marcel.wiesweg, tschenser |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.1.0 | |
| Sentry Crash Report: | |||
|
Description
S. Burmeister
2010-01-03 15:10:14 UTC
Raw thumbnails are generated using JPEG embeded in Raw container. there are not relevant of Raw image data. Rotation can be different for both. Yes, it's a shame, but there is not rotation information for jpeg _and_ raw. It's the same flags for both. Gilles Caulier Can you provide a sample picture? I can confirm this also for my NEF's. The results from BQM are: convert to jpeg: rotated, but exif is the same as original (wrong) convert to png: rotated, but exif is the same as original (wrong) convert to tiff: rotated, exif set to normal (right) I think this one is caused by https://bugs.kde.org/show_bug.cgi?id=202278. Do convert tools need a setNeedResetExifOrientation(true) to? Jens RAW files are autorotated by dcraw already. Currently looking at dimginterface.cpp:351, where only for JPEG, PNG and TIFF the Exif flag is used at all. I'm not sure if that is correct, e.g. for JPEG2000 or PGF. At least it seems that when having a fully loaded RAW (not a preview) and saving that in a different format, for which the exif flag is honoured, the metadata cannot just be copied, the flag must be reset. >I'm not sure if that is correct, e.g. for JPEG2000 or PGF.
Yes, it is for JP2 and PGF
Gilles
Sorry Gilles... ;-) It is correct or it is not correct to ignore the Exif rotation flag for JPEG2000 and PGF? JPEG2000 support Exif and XMP offcially. You must check rotation flag here. For PGF, Exif is supported through Exiv2 0.19 now, with my patch. Same way... Gilles SVN commit 1072176 by mwiesweg: Rotate by exif orientation for all images except RAWs. Previously, this was restricted to JPG/PNG/TIFF. CCBUG: 221113 M +4 -17 dimginterface.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1072176 SVN commit 1072206 by mwiesweg: Reset exif orientation, regardless if the tools requested that, if the DImg was loaded from RAW. (it's done similarly in the image editor, where a flag is set that the image was rotated if it is RAW, and subsequently the orientation is reset) CCBUG: 221113 M +1 -1 imageeditor/canvas/dimginterface.cpp M +6 -5 queuemanager/batchtool.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1072206 Everyone here, can you test if this is fixed now for your usecase? - converting RAW is fine for me (tested jpg & tiff & png) - converting a jpg with exif-rotation flag set, the rotation flag is not preserved in tiff TIFF is a different problem, metadata writing is disabled for now, bug 211758. ok, beside the tiff issue everthing is fine for me |