Bug 220645

Summary:	cover image with 'save link only' gets stored as local file
Product:	[Applications] tellico	Reporter:	martinrssf <martinrssf>
Component:	general	Assignee:	Robby Stephenson <robby>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	2.1.1
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed In:

Description martinrssf@gmail.com 2009-12-30 08:36:11 UTC

Version:           2.1.1 (using KDE 4.3.3)
OS:                Linux
Installed from:    Fedora RPMs

When entering new image in cover with 'Save link only' checked, the file URL path is erroneously converted to simple file name with any slash or colons removed. For example, file:///home/me/myimage/abc.jpg will become homememyimageabc.jpg. Then an error occurs with message:
  Could not start process Unable to create io-slave: klauncher said: Unknown protocol ''.

A related problem is that if I open a cover image in edit entry form that already exists with 'Save link only', that act itself creates a local image file in the directory.

This never happened before 2.1.1.

It looks like any image with 'Save link only' checked is still thought as a local file to be stored in the database.

The only resolution is to hand-edit the xml file and modify <cover>..</cover> and <image...link="true".../> entries each time a cover image with 'Save link only' is input, and delete the local image file.

Comment 1 martinrssf@gmail.com 2009-12-30 08:41:23 UTC

additional info regarding the related problem.

The icon files get saved in the local directory as soon as the icons are viewed, not just at the entry form. 'Save link only' doesn't work anymore.

Comment 2 martinrssf@gmail.com 2009-12-31 02:01:10 UTC

After checking the source, it looks like Image::setID(id_) always sets idClean(id_), losing the slashes and colons, whether m_linkOnly or not.

Comment 3 Robby Stephenson 2009-12-31 20:22:54 UTC

SVN commit 1068297 by rstephenson:

Don't clean the image id if it's only a link
BUG:220645


 M  +3 -3      gui/imagewidget.cpp  
 M  +4 -0      images/CMakeLists.txt  
 M  +2 -1      images/image.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1068297

Comment 4 Robby Stephenson 2009-12-31 20:33:25 UTC

SVN commit 1068300 by rstephenson:

Don't attempt to write out temporary file for linked images
BUG:220645


 M  +4 -0      ChangeLog  
 M  +8 -4      src/entryview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1068300