Bug 220180

Summary:	Remember selection action setting on switching selection tool
Product:	[Applications] krita	Reporter:	Grósz Dániel <groszdanielpub>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bugs_kde_org2, halla, miabraha
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	http://commits.kde.org/krita/73a125f71cbd1f0af2e0cce820e6dbc7a5cf80d5	Version Fixed In:
Sentry Crash Report:

Description Grósz Dániel 2009-12-26 23:01:18 UTC

Version:           2.1.0 (using KDE 4.3.4)
OS:                Linux
Installed from:    openSUSE RPMs

Currently the Action (Replace/Add/...) parameter of the different selection tools is handled independently. I think that if we use selection tools several times in succession, it usually does not matter from the perspective of the process of creating a selection with several additions, substractions or intersections that sometimes this or that selection tool is the most suitable.

I propose that the Action setting of the selection tools be common. This way e. g. if you add several parts of the image to your selection, you wouldn't have to set the Action parameter of selection tools several times if for different parts of the image you use different tools.

Comment 1 Halla Rempt 2011-05-26 22:13:30 UTC

This would be very useful, but I'm not sure how it's going to work with the selection refactor plan. Still, definitely confirmed as needed polish.

Comment 2 Halla Rempt 2011-10-09 12:54:08 UTC

We should use the canvas resource provider here. It can't be very difficult to do, actually.

Comment 3 Halla Rempt 2016-01-24 14:15:29 UTC

WISHGROUP: Small Usability Fixes

Comment 4 Michael 2016-06-23 21:28:13 UTC

Six and a half years later this is implemented (=

https://phabricator.kde.org/rKRITAd850ff238bd6b34aa6e5c7438d27d0f9791f3529

Comment 5 Halla Rempt 2016-06-24 06:48:14 UTC

Git commit 73a125f71cbd1f0af2e0cce820e6dbc7a5cf80d5 by Boudewijn Rempt, on behalf of Michael Abrahams.
Committed on 24/06/2016 at 06:09.
Pushed by rempt into branch 'krita/3.0'.

Share selection options across tools

Use KisCanvasResourceProvider to synchronize the options across the
various tool widgets.

M  +23   -0    libs/ui/kis_canvas_resource_provider.cpp
M  +11   -1    libs/ui/kis_canvas_resource_provider.h
M  +43   -17   libs/ui/tool/kis_selection_tool_config_widget_helper.cpp
M  +9    -5    libs/ui/tool/kis_selection_tool_config_widget_helper.h
M  +0    -6    libs/ui/tool/kis_tool_select_base.h
M  +20   -14   libs/ui/widgets/kis_selection_options.cc
M  +4    -0    libs/ui/widgets/kis_selection_options.h

http://commits.kde.org/krita/73a125f71cbd1f0af2e0cce820e6dbc7a5cf80d5

Comment 6 Halla Rempt 2016-06-24 08:59:55 UTC

Yay :-)