Summary: | Crash while creating dynamic playlist | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | soopaseb <soopaguard-linuxfr> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | lfranchi |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
soopaseb
2009-12-23 23:17:58 UTC
try removing any saved dynamic playlists with a custom bias (last.fm or echonest). can you still get it to crash? commit 52244b2ec7d48b99142f2bab09c3877f43fc4d72 Author: Leo Franchi <lfranchi@kde.org> Date: Wed Dec 23 23:57:27 2009 -0600 null pointer guard CCBUG: 219888 diff --git a/src/dynamic/CustomBias.cpp b/src/dynamic/CustomBias.cpp index 0500488..8cda32c 100644 --- a/src/dynamic/CustomBias.cpp +++ b/src/dynamic/CustomBias.cpp @@ -106,6 +106,11 @@ Dynamic::CustomBias::reevaluate( double oldEnergy, const Meta::TrackList& oldPla { DEBUG_BLOCK Q_UNUSED( context ) + + if( !m_currentEntry ) // wtf it died under us, return oldEnergy + { + return oldEnergy; + } double offset = 1.0 / (double)oldPlaylist.size(); (In reply to comment #1) > try removing any saved dynamic playlists with a custom bias (last.fm or > echonest). can you still get it to crash? Ok, i removed the custom bias and it has not crashed yet. Hope this bias will work again... thx for the help. the fix I just committed should stop the crash. i'm not sure why that was happening---i didn't solve the root cause, just stopped it from crashing. the fix should be in 2.2.2. |