Bug 219637

Summary: (kcmhistory) history settings sets old/new boxs wrong on changes
Product: [Applications] konqueror Reporter: Xbehave <Rioting_pacifist>
Component: generalAssignee: Konqueror Bugs <konqueror-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal    
Priority: NOR    
Version First Reported In: Git   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Unspecified   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Xbehave 2009-12-22 06:31:53 UTC 
Version:            (using Devel)
Installed from:    Compiled sources

The KCM history modules (http://lxr.kde.org/source/KDE/kdebase/apps/konqueror/sidebar/history_module/) handles units incorrectly.

lines 214 & 226 are wrong
http://lxr.kde.org/source/KDE/kdebase/apps/konqueror/sidebar/history_module/kcmhistory.cpp#214

Does something bad happen if your Older date is younger than your Newer than date? I mean it's a stupid setting to have, but if it doesn't cause any bugs then just let it be and let users have weird settings
e.g red for younger than 1 day and italics for older than 12hrs
If that's acceptable then removed those lines, if not then you need to do something like (i don't know c++)

is it safe to multiply the value of a combobox by 1440, as it could go over maxint, maybe the max value for the boxes should be 1440 times smaller)


if comboOlder.CurrentIndex() == comboNewer.CurrentIndex():
   current check
else:
    older = comboOlder.CurrentIndex()
    newer = comboNewer.CurrentIndex()
    if comboOlder.CurrentIndex() == Days: older *= 1440
    else: newer *= 1440
    if older < newer: 
        if comboNewer.CurrentIndex() == Days: spinnerNewer == newer/1440
        else: spinnerNewer == newer

and something similar for the other one.
Comment 1 Andrew Crouthamel 2018-11-06 15:08:21 UTC 
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 Andrew Crouthamel 2018-11-17 04:55:26 UTC 
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Justin Zobel 2022-12-14 03:09:08 UTC 
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 4 Bug Janitor Service 2022-12-29 05:22:57 UTC 
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2023-01-13 05:13:51 UTC 
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!