Summary: | kstars crash due to stack smashing "attack" when compiled with -fstack-protector-all | ||
---|---|---|---|
Product: | [Applications] kstars | Reporter: | Hugo Mildenberger <Hugo.Mildenberger> |
Component: | general | Assignee: | Akarsh Simha <akarsh.simha> |
Status: | RESOLVED NOT A BUG | ||
Severity: | crash | CC: | alexey.skladnoy, mutlaqja |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | patch against kstars/kstars/skyobjects/saturnmoons.cpp |
Description
Hugo Mildenberger
2009-12-19 12:41:33 UTC
Created attachment 39192 [details] patch against kstars/kstars/skyobjects/saturnmoons.cpp This patch fixes four issues: 1.) The author assumed C arrays would start with element 1. The consequence was a stack smashing "attack" detected when compiled with -fstack-protector-all 2.) summing up angles given in degrees with angles given in radians: see double u = 2*W5 - 2*theta + psi; 3.) remove unnecessary calls to MapTo0To360Range 4.) remove unused, superflous arrays declarations HOWEVER: Saturn's moons positions still appear to be wrong when compared to the output of JPL's solar system simulator for any given date (here: http://space.jpl.nasa.gov/) Thank you for bug report and patch but code for Saturn moons was removed due to copyright violation. I'm therefore closing the bug. |