Bug 218811

Summary:	tied zoom icon does not always correspond to the current status
Product:	[Applications] kst	Reporter:	Grégoire Verlut <gregoire.verlut>
Component:	general	Assignee:	kst
Status:	RESOLVED FIXED
Severity:	normal	CC:	netterfield
Priority:	NOR
Version:	2.0.0
Target Milestone:	2.0.0
Platform:	unspecified
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Grégoire Verlut 2009-12-15 17:05:47 UTC

Version:           2.0.0_devel (using unspecified)
Compiler:          mingw, coming with QT Creator 
OS:                Windows 32-Bit

-open a kst file with (at least) 2 tabs.
-in the first tab activate the "tied zoom" icon, verify that it properly works by zooming on one plot
-go the 2nd tab, "tied zoom" icon is still activated, verify that it properly works by zooming on one plot
-deactivate the "tied zoom" icon, verify that it properly works by zooming on one plot
-go back to the first tab, the "tied zoom" icon looks deactivated, but zooming in one plot will zoom all the plots.

-reactivate the "tied zoom" by clicking on the icon.
-go to the second tabs, the "tied zoom" icon looks activated, but zooming in one plot does not zoom the others plots.

Comment 1 Netterfield 2010-01-05 02:08:10 UTC

The current behavior is clearly wrong.  However, the correct behavior is not entirely clear: the 'Tied Zoom' indicators are actually active, so you can just tie some of them by clicking on them.  In that case, what should the tool-bar toggle do?

I think that the Toolbar icon should be a pushbutton, not a toggle, and will either set all of the tied zoom indicators, or unset them all, depending on if there are more tied or un-tied plots in the current view.

(There is also the issue that the tied zoom indicators don't look pushable... but that is a different story.)

Thoughts?

Comment 2 Nicolas Brisset 2010-01-07 14:45:21 UTC

I agree with you: clicking on the button toggles all the tied indicators to the opposite of the current majority status. Clicking on one toggles only that one.

One question may remain: do we want to toggle only the current window, or all windows? I'd prefer all windows if they can be zoomed together, otherwisw only the current window.

Comment 3 Netterfield 2010-01-07 16:33:45 UTC

SVN commit 1071118 by netterfield:

Remove size settings from legend dialog.
BUG: 219844
Tied Zoom button becomes a push button.  Plots vote on whether to get set or not.
BUG: 218811

Fix a crash when grouped plots are tied.



 M  +0 -11     devel-docs/Kst2Specs/Wishlist  
 M  +1 -0      src/libkstapp/legenditem.cpp  
 M  +4 -4      src/libkstapp/mainwindow.cpp  
 M  +1 -1      src/libkstapp/mainwindow.h  
 M  +20 -5     src/libkstapp/plotitemmanager.cpp  
 M  +1 -1      src/libkstapp/plotitemmanager.h  
 M  +4 -0      src/libkstapp/sharedaxisboxitem.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1071118

Comment 4 Peter Kümmel 2010-08-14 12:14:31 UTC

Change version from 2.0.0_devel to 2.0.0 to simplify version numbering.

Comment 5 Peter Kümmel 2010-11-12 10:42:17 UTC

These bugs are solved with 2.0.0