Bug 218019

Summary: kpat stops processing mouse actions
Product: [Applications] kpat Reporter: Christopher Neufeld <kdebugs>
Component: generalAssignee: Stephan Kulow <coolo>
Status: VERIFIED FIXED    
Severity: normal CC: coates, dimsuz, kde-games-bugs
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Christopher Neufeld 2009-12-09 19:07:10 UTC
Version:            (using Devel)
Compiler:          gcc-4.2.4 
OS:                Linux
Installed from:    Compiled sources

In revision 1060335, when playing the freecell game in kpat, the game stops processing mouse events after a few moves.  It is no longer possible to move cards with the mouse, so you have to give up the game.  The menu items still work, you can undo moves or visit the configuration settings, but button pushes in the game window appear to be unseen.

A quick strace of the binary shows that the events are being delivered, there is a flurry of output every time the mouse button is pushed, but the game is not responding to these mouse clicks.
Comment 1 Parker Coates 2009-12-10 14:38:20 UTC
Is Freecell the only game affected? Does the mouse start working again if you change to a different game type and change back? What about if you start a new deal? Are rightclicks still handled?

Thanks.
Comment 2 Christopher Neufeld 2009-12-10 15:14:16 UTC
I tried Klondike and Spider, neither one of those exhibited the problem.

If you click a new game in the menu bar, you can go back and choose another Freecell game, and you'll get another three or four clicks out of the new game before it, too, gives up.  After left mouse clicks stop working, right clicks are still handled.

If, when the game has stopped accepting mouse clicks, you click on "new deal" rather than "new game", you get the warning message that you're going to be charged with a lost game, but nothing further happens.  No new deal is created.  You can still, at this point, click "New game" and go back to the game selector.
Comment 3 Andreas Pakulat 2009-12-12 02:33:52 UTC
I ran into this today with Freecell and also Spider. In Spider it only happens once you complete a run (i.e. get a complete list of King down to Ace built up so it moves to the bottom-left). At that point things stop to work.

In Freecell it triggers when moving more than one card. 

Whats interesting is that Spider can be "healed" for the rest of the game by saving and then loading the game again. After that no further completed runs will break the mouse-handling.

In Freecell this doesn't help, after loading the very next multi-card-move will again make mouse actions drop.

Besides Spider and Freecell, I also checked Klondike and Grandfather's Clock and neither have a problem.

I mailed to kde-games and Parker suggested to try out the Demo modes. The result is that in Freecell the Demo mode doesn't exhibit the problem as it never uses the multi-card-move feature. In Spider the Demo Mode doesn't break when it completes a run, so it has got to do something with user-interaction in some way.

Trying to use the demo button to "move on" in the game once the mouse stopped working doesn't seem to help. Pressing the Demo button simply does nothing in Spider or Freecell if the clicks are not working anymore.
Comment 4 Dmitry Suzdalev 2009-12-14 20:08:02 UTC
Today I tried to play Idiot and hit this bug.
(perhaps I should have played a smart person instead ;))

Can't help to reproduce right now or provide some additional info - i'm away from that machine atm.
Comment 5 Andreas Pakulat 2009-12-14 22:36:33 UTC
Finally Parker identified the reason for the regression. I've just reverted the problematic change in r1062474. It shows that there are still some issues with the animation-code, but at least Freecell and Spider work now again.
Comment 6 Christopher Neufeld 2009-12-18 00:45:21 UTC
I am the original reporter, and I can verify that in revision 1063248 the bug no longer appears.