Bug 217721

Version:            (using Devel)
Installed from:    Compiled sources

if i open KTimetracker inside kontact and try to do Ctrl + Maj +  W  it crashes all the times :

Here is a possible patch and the backtrace.


Can i commit this patch ?

Index: ktimetracker/timetrackerwidget.cpp
===================================================================
--- ktimetracker/timetrackerwidget.cpp  (révision 1059831)
+++ ktimetracker/timetrackerwidget.cpp  (copie de travail)
 -476,8 +476,11 @@
             d->mIsNewVector.remove( d->mIsNewVector.indexOf( taskView ) );
         }
     }
-    taskView->save();
-    taskView->closeStorage();
+    if (taskView)
+    {
+      taskView->save();
+      taskView->closeStorage();
+    }

     d->mTabWidget->removeTab( d->mTabWidget->currentIndex() );
     d->mSearchWidget->removeTreeWidget( taskView );


Thread 1 (Thread 0xb329a8e0 (LWP 23863)):
[KCrash Handler]
#6  0xad34d810 in TaskView::save (this=0x0) at /usr/src/debug/kdepim-4.3.80/ktimetracker/taskview.cpp:679
#7  0xad361e67 in TimetrackerWidget::closeFile (this=0xa33f050) at /usr/src/debug/kdepim-4.3.80/ktimetracker/timetrackerwidget.cpp:479
#8  0xad3687df in TimetrackerWidget::qt_metacall (this=0xa33f050, _c=QMetaObject::InvokeMetaMethod, _id=15, _a=0xbf9de828) at /usr/src/debug/kdepim-4.3.80/build/ktimetracker/timetrackerwidget.moc:199
#9  0xb6cefd5d in QMetaObject::metacall (object=0xa33f050, cl=3053491088, idx=42, argv=0xbf9de828) at kernel/qmetaobject.cpp:237
#10 0xb6cfeb56 in QMetaObject::activate (sender=0xa351360, m=0xb6b64058, local_signal_index=1, argv=0xbf9de828) at kernel/qobject.cpp:3286
#11 0xb6219ced in QAction::triggered (this=0xa351360, _t1=false) at .moc/release-shared/moc_qaction.cpp:263
#12 0xb621bf4c in QAction::activate (this=0xa351360, event=QAction::Trigger) at kernel/qaction.cpp:1245
#13 0xb621d9e0 in QAction::event (this=0xa41fc88, e=0xa41fc88) at kernel/qaction.cpp:1162
#14 0xb71888df in KAction::event () from /usr/lib/libkdeui.so.5
#15 0xb62206ac in QApplicationPrivate::notify_helper (this=0x99ee4a8, receiver=0xa351360, e=0xbf9decc8) at kernel/qapplication.cpp:4242
#16 0xb62274d0 in QApplication::notify (this=0xbf9dfad4, receiver=0xa351360, e=0xbf9decc8) at kernel/qapplication.cpp:3661
#17 0xb72790b1 in KApplication::notify () from /usr/lib/libkdeui.so.5
#18 0xb6cea9ee in QCoreApplication::notifyInternal (this=0xbf9dfad4, receiver=0xa351360, event=0xbf9decc8) at kernel/qcoreapplication.cpp:704
#19 0xb6262735 in QShortcutMap::dispatchEvent (this=0x99ee554, e=0xbf9df0d4) at ../../src/corelib/kernel/qcoreapplication.h:215
#20 0xb6264662 in QShortcutMap::tryShortcutEvent (this=0x99ee554, o=0xa33f050, e=0xbf9df0d4) at kernel/qshortcutmap.cpp:364
#21 0xb62290d9 in QApplication::notify (this=0xa33f050, receiver=0xa33f050, e=0xbf9df0d4) at kernel/qapplication.cpp:3703
#22 0xb72790b1 in KApplication::notify () from /usr/lib/libkdeui.so.5
#23 0xb6cea9ee in QCoreApplication::notifyInternal (this=0xbf9dfad4, receiver=0xa33f050, event=0xbf9df0d4) at kernel/qcoreapplication.cpp:704
#24 0xb62215dd in qt_sendSpontaneousEvent (receiver=0xa33f050, event=0xa41fc88) at ../../src/corelib/kernel/qcoreapplication.h:218
#25 0xb62d9b93 in QKeyMapper::sendKeyEvent (keyWidget=0xa33f050, grab=false, type=QEvent::KeyPress, code=87, modifiers=) at kernel/qkeymapper_x11.cpp:1861
#26 0xb62dc1d2 in QKeyMapperPrivate::translateKeyEvent (this=0x9a32d78, keyWidget=0xa33f050, event=0xbf9df77c, grab=136) at kernel/qkeymapper_x11.cpp:1831
#27 0xb62b1286 in QApplication::x11ProcessEvent (this=0xbf9dfad4, event=0xbf9df77c) at kernel/qapplication_x11.cpp:3394
#28 0xb62df5f8 in x11EventSourceDispatch (s=0x99f8f40, callback=0, user_data=0x0) at kernel/qguieventdispatcher_glib.cpp:146
#29 0xb40c5b52 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#30 0xb40c9428 in ?? () from /usr/lib/libglib-2.0.so.0
#31 0xb40c954e in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#32 0xb6d17651 in QEventDispatcherGlib::processEvents (this=0x99ea730, flags={i = 36}) at kernel/qeventdispatcher_glib.cpp:407
#33 0xb62df14a in QGuiEventDispatcherGlib::processEvents (this=0x99ea730, flags={i = 36}) at kernel/qguieventdispatcher_glib.cpp:202
#34 0xb6ce904d in QEventLoop::processEvents (this=0xbf9dfa34, flags=) at kernel/qeventloop.cpp:149
#35 0xb6ce9499 in QEventLoop::exec (this=0xbf9dfa34, flags={i = 0}) at kernel/qeventloop.cpp:201
#36 0xb6ced620 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:981
#37 0xb6220754 in QApplication::exec () at kernel/qapplication.cpp:3570
#38 0x0804b236 in main (argc=1, argv=0xbf9dfcf4) at /usr/src/debug/kdepim-4.3.80/kontact/src/main.cpp:221