| Summary: | Knotes always remembers the note's original desktop | ||
|---|---|---|---|
| Product: | [Unmaintained] knotes | Reporter: | Nicolas Galler <ngaller> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | adaptee, winter, wooolfy |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdepim/052679628f639bc7420e8e8b3f20573aa082c840 | Version Fixed In: | 4.10.1 |
| Sentry Crash Report: | |||
| Attachments: | Alows proper working of "Remember Desktop" option in knotes (v4.8.5) | ||
Created attachment 77023 [details]
Alows proper working of "Remember Desktop" option in knotes (v4.8.5)
Hi.
Because I experience similar broken behaviour as describer in this Bug, I have prepared fix which might be considered as solution for this issue.
Since I'm using Mageia 2 this patch is prepared for version 4.8.5 of PIM, however might work on newer releases.
Thank you for the patch. Please submit it to http://reviewboard.kde.org. You will need an account on http://identity.kde.org for that. Also please have a look at the commit rules for KDE: http://techbase.kde.org/Policies/SVN_Commit_Policy (that applies to Git as well) The patch looks fine. I will commit it for KDE 4.10.1 and above. Thanks! Git commit 052679628f639bc7420e8e8b3f20573aa082c840 by Allen Winter. Committed on 10/02/2013 at 16:26. Pushed by winterz into branch 'KDE/4.10'. Make "remember desktop" option work properly. Thanks for the patch wooolfy FIXED-IN: 4.10.1 M +5 -0 knotes/knote.cpp M +5 -2 knotes/knote.h M +6 -2 knotes/knotesapp.cpp http://commits.kde.org/kdepim/052679628f639bc7420e8e8b3f20573aa082c840 Glad I could help. That was one of those small but annoying bugs. Thanks for review and commitment Allen, that saves my time going through whole process. |
Version: (using KDE 4.3.2) OS: Linux Installed from: Ubuntu Packages I checked off the "Remember Desktop" box in Knotes. However, when I enter a new note, it still seems to stick it on the one desktop that it was entered on originally. For example, if I am on desktop 1, and add a note, then right click on KNotes, click "Hide all notes", switch to desktop 2, right click on KNotes and click "Show all notes", the note I just added does not show. If I switch back to desktop 1 I can see it opened there. I expected all notes to open on my current desktop, desktop 2. Another example: if I close the note, switch to desktop 2, left click on the KNotes icon, and select the note I just added, the system switches to desktop 1 automatically, where the note is open (I would expect it to open on the current desktop, desktop 2, instead). I checked the note's file itself (libcal-nnnnn under .kde4/share/apps/knotes/notes) and it has this data: [Display] RememberDesktop=false bgcolor=255,255,189 [General] version=3.9 [WindowDisplay] desktop=1 position=54,271 My system's version data is below. Description: Ubuntu 9.10 Release: 9.10 kdepim: Installed: 4:4.3.2-0ubuntu6 Candidate: 4:4.3.2-0ubuntu6 Version table: *** 4:4.3.2-0ubuntu6 0 500 http://us.archive.ubuntu.com karmic/main Packages 100 /var/lib/dpkg/status ProblemType: Bug Architecture: amd64 Date: Mon Nov 30 11:39:42 2009 DistroRelease: Ubuntu 9.10 ExecutablePath: /usr/bin/knotes InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release amd64 (20091027) NonfreeKernelModules: nvidia Package: knotes 4:4.3.2-0ubuntu6 ProcEnviron: LANG=en_US.UTF-8 SHELL=/bin/bash ProcVersionSignature: Ubuntu 2.6.31-14.48-generic SourcePackage: kdepim Uname: Linux 2.6.31-14-generic x86_64