| Summary: | amarok crashes when tagging m4a | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] taglib | Reporter: | Jeremy <freeshit> |
| Component: | general | Assignee: | Lukáš Lalinský <lalinsky> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | kde, kirsch.andreas, lalinsky, lyall, splash.master.unix, vnieto, wuseldusel |
| Priority: | NOR | ||
| Version: | 1.6 | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | mp4 file that kills amarok too | ||
|
Description
Jeremy
2009-11-30 15:41:00 UTC
The crash appears to be in taglib, reassigning can you please install the debug packages from you distribution ? Will do. However, I'm new to bug reporting. Do you want me to replicate
the problem and send in a nother bug report or would you rather have me
run some sort of debugging tool? I have archlinux x64 with gnome for a
desktop FYI.
On Mon, 2009-11-30 at 16:03 +0100, Nicolas Lécureuil wrote:
> https://bugs.kde.org/show_bug.cgi?id=216819
>
>
> Nicolas Lécureuil <nlecureuil@mandriva.com> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |nlecureuil@mandriva.com
>
>
>
>
> --- Comment #2 from Nicolas Lécureuil <nlecureuil mandriva com> 2009-11-30 16:03:48 ---
> can you please install the debug packages from you distribution ?
>
If this happens only for some specific files, can you please send me one of them to lalinsky@gmail.com? If it crashes on any MP4 file, it's most likely a configuration/build issue. Jeremy, can you please send me the problematic file? It's not possible to debug the issue without it. *** Bug 218493 has been marked as a duplicate of this bug. *** This is not the same file I was using when this bug was reported (can't find that one). However, I tried to rename this file today, and it crashed. It seems to happen with mp4 files only. Let me know if I can be of any more assistance. -----Original Message----- From: Lukáš Lalinský <lalinsky@gmail.com> Reply-to: bug-control@bugs.kde.org To: freeshit@mr-awesome.com Subject: [Bug 216819] amarok crashes when tagging m4a Date: Sat, 12 Dec 2009 17:47:40 +0100 (CET) https://bugs.kde.org/show_bug.cgi?id=216819 --- Comment #5 from Lukáš Lalinský <lalinsky gmail com> 2009-12-12 17:47:37 --- Jeremy, can you please send me the problematic file? It's not possible to debug the issue without it. Created attachment 39053 [details]
mp4 file that kills amarok too
I can also confirm that after amarok crashed trying to rename the file I just sent you.. I tried several other m4a files, and they worked great. No problems at all. I then tried to rename the probelm file again... and sure enough, Amarok crashed again. Hope this helps. The uploaded file is a 44 bytes long WAVE file. Are you sure it's the right one? Even with this file there are issues though. Because the low-level structure of WAVE and MP4 is actually quite similar, it tried to write to the file as if it was a MP4 file, which didn't work. But as the file is so short, I'm not sure if the other files in your collection failed for the same problem. The worst alternative I can think of is that the WAVE file was actually longer, but TagLib truncated it when it assumed it was an MP4 file, because it had a .m4a extension. SVN commit 1062426 by lalinsky: Be more paranoid about checking MP4 files To consider something a valid MP4 file, it must have a 'moov' atom. Otherwise it's marked as invalid and we won't try to read/write tags. CCBUG:216819 M +7 -0 taglib/mp4/mp4file.cpp M +9 -0 tests/test_mp4.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1062426 wtf??? I thought that file was larger... In fact... I don't even know why it is on my HD in the first place. Sorry for wasting your time there. I will be sorting through my hard drive, and will get back to you with a real file that is problematic or consider this bug no longer a bug. I remember when this happened, I had a file that was larger and was an m4a. I have renamed several m4as this morning so either that bug is fixed or I am losing my mind. Anyway... I will keep you posted. Definitely no time was wasted. The short file triggered a bug that could cause bad problems. This will be fixed in the next version of TagLib. I'll keep this bug report open for now. If you find any crash on a .m4a file that could be related to this, please let me know. Thanks. well... I went through my files... No m4a does not work correctly now. I cannot replicate the problem with any file except the one I sent you previously. *** Bug 223753 has been marked as a duplicate of this bug. *** *** Bug 224425 has been marked as a duplicate of this bug. *** *** Bug 218493 has been marked as a duplicate of this bug. *** *** Bug 257117 has been marked as a duplicate of this bug. *** *** Bug 256311 has been marked as a duplicate of this bug. *** I'm going to close this bug, as there isn't much more that I can do. It's now more careful about what it has on input. |