| Summary: | Option to set parent album in Album -> New Album | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Dotan Cohen <kde-2011.08> |
| Component: | Albums-MainView | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, georg.wittenburg, kde-2011.08, krivakin, smit.meh |
| Priority: | NOR | ||
| Version: | 2.4.1 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | 2.6.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Patch for bug 216636
Patch for bug 216636 (final) |
||
|
Description
Dotan Cohen
2009-11-29 12:43:05 UTC
you want mean a new root collection, as you can see in setup collection dialog ? Gilles Caulier No. Currently, when choosing Album -> New Album the newly formed album is created as a sub-album of the current album. That is not always what the user wants. There should be an option to select where in the tree to place the new album, or at the very least an option to make it a top-level album. I'm all for this. Actually, I'm wondering why it isn't the default to create new albums in the collection root. Sub-albums really feels more like something for advanced users, while a plain flat hierarchy is what newbies would expect (I guess). Furthermore, if no album is selected Album->New... is grayed out, which doesn't make much sense. Can be it is necessary to make so: If it is selected a root collection or it is selected nothing, the window of creation of a new collection (same as Configure-> Collections-> Add collection) opens. Dotan, This file still valid using digiKam 2.4 ? Gilles Caulier Yes, this is still valid. To reproduce: 1) In the main menu, select Album -> New... -> OK 2) There is no step 2. It can be seen that the new album is a subalbum of the current album. Intuitively it should be a top-level album. Hi Dotan Suppose you want an album at position 'X' in the album hierarchy. Make your current selection to be the parent of 'X' and go for a new album. Wont this solve the issue? Smit Hi Dotan Kindly reply to my comment. Is it helpful? If it isnt, kindly explain your problem a bit more elaborately, may be with a screen shot. Smit > Suppose you want an album at position 'X' in the album hierarchy. Make your current selection
> to be the parent of 'X' and go for a new album. Wont this solve the issue?
>
That is the current work-around, Smit.
However the bug is not the fact that one cannot create an album in the place of his desire, but rather the unexpected behaviour regarding the positioning of the new album. If the menu item were labelled "New Sub-Album" then the current behaviour would be intuitive, but as the label states "New Album" intuition expects it to be placed top-level.
Thank you!
Hi Gilles What do you suggest after reading Dotan's comment? Smit 2 solutions. 1/ Rename "New Album" as "New Sub Album" in this dialog and contextual menu. 2/ Add an option in dialog to be able to choose where new album will be plug in hierarchy, as a sub album of current selected (default) or as root of hierarchy... Dotan, this respond to your problem ? Gilles Caulier I wouldn't call it "my problem" but it does address the issue! This was actually brought to my attention from another Digikam user. I think that the second solution is preferable. Thanks Gilles and Smit! Created attachment 69934 [details] Patch for bug 216636 Hi Gilles Kindly go through the above patch. It produces desired results in my system. If it is fine with you, i shall commit it. Smit Created attachment 69936 [details] Patch for bug 216636 (final) Hi Gilles This is the latest patch. Previous patch has indentation issues. Smit Git commit b17893e9768e6ed020a649e68d238b16c2c7f145 by smit mehta. Committed on 28/03/2012 at 15:36. Pushed by smitmehta into branch 'master'. Adding an option to select the parent in creation of new album CCMAIL:caulier.gilles@gmail.com M +4 -7 digikam/album/albummodificationhelper.cpp M +53 -9 digikam/album/albumpropsedit.cpp M +3 -1 digikam/album/albumpropsedit.h http://commits.kde.org/digikam/b17893e9768e6ed020a649e68d238b16c2c7f145 |