Bug 216239

Summary: not all bookmarks are saved when using two and more copied of okular
Product: [Applications] okular Reporter: Ilya Zonov <izonov>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Ilya Zonov 2009-11-26 11:27:11 UTC 
Version:           0.9.3 (using 4.3.3 (KDE 4.3.3), Gentoo)
Compiler:          i686-pc-linux-gnu-gcc
OS:                Linux (i686) release 2.6.30-gentoo-r8

If I open two or more files in okular (two or more windows) and add some bookmarks for each file, then are saved bookmarks only from last closing file.
Comment 1 Albert Astals Cid 2009-12-23 23:32:59 UTC 
Can you specify the exact steps you do, because it seems to work for me.
Comment 2 Ilya Zonov 2009-12-24 22:06:31 UTC 
1. Open first file in okular [1]: 
   # okular 1.pdf
2. Add some bookmarks;
3. Open second file in other okular window [2]:
   # okular 2.pdf
4. Add some bookmarks for second file;
5. Close okular [1];
6. Close okular [2];
7. Open new okular and look which bookmarks were saved. (Saved only bookmarks from okular [2]).
Comment 3 Pino Toscano 2009-12-26 17:57:12 UTC 
SVN commit 1066286 by pino:

Change the saving strategy for bookmarks: instead of saving them manually or at closing, save them after each action.
This should avoid any bookmark loss due to premature crash or similar abnormal closing.
BUG: 157246
BUG: 213206
Also, the above change triggers the D-Bus synchronisation of the internal bookmark manager of the various Okular instances;
react to those changes properly by updating the own info (because of the changes in the bookmark manager of another instance).
BUG: 216239

On the technical note, keep the cache of known file just with the bookmark address instead of the group itself
(which gets changed behind our back).


 M  +98 -25    bookmarkmanager.cpp  
 M  +2 -0      bookmarkmanager.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1066286