Bug 215482

Summary:	[Patch] Every paintEvent emits a D-Bus signal
Product:	[Applications] marble	Reporter:	Dennis Nienhüser <nienhueser>
Component:	general	Assignee:	Dennis Nienhüser <nienhueser>
Status:	RESOLVED FIXED
Severity:	normal	CC:	marble-bugs
Priority:	NOR
Version:	unspecified
Target Milestone:	0.8 (KDE 4.3)
Platform:	Ubuntu
OS:	Unspecified
Latest Commit:		Version Fixed In:
Attachments:	marble-dbus-fps-signal.diff

Description Dennis Nienhüser 2009-11-20 21:48:09 UTC

Version:            (using KDE 4.3.3)
Installed from:    Ubuntu Packages

When running dbus-monitor, I noticed that marble sends out loads of dbus signals that nobody listens to. I think what's happening is that in MarbleMap::paintEvent, the framesPerSecond signal is emitted, which gets emitted over dbus because of the QDBusConnection::ExportAllSignals registration type.
I think that shouldn't be the case, at least the emission of the signal should be explicitly requested.

Comment 1 Dennis Nienhüser 2010-01-02 11:07:34 UTC

Created attachment 39498 [details]
marble-dbus-fps-signal.diff

Patch makes fps calculation and signal emission conditional on the maps' showFramerate setting. If nobody objects, I'll commit that.

Comment 2 Dennis Nienhüser 2010-01-04 16:23:25 UTC

r1069964 | nienhueser | 2010-01-04 16:21:13 +0100 (Mon, 04 Jan 2010) | 2 lines

No unnecessary framerate calculations and signal emissions. BUG: 215482