| Summary: | Layout of pop-up window completely broken | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Andrey Borzenkov <arvidjaar> |
| Component: | widget-battery | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, aspotashev, notmart, quantumphazor, sebas, shafff, wrar |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
battery widget pop-up
battery widget in 4.3.80 Battery popup in 4.4 RC1 4.4.0 |
||
|
Description
Andrey Borzenkov
2009-11-20 18:09:53 UTC
Created attachment 38464 [details]
battery widget pop-up
The widget received some polishment recently. Could you check this with the latest KDE ? Thanks It is better in beta1 (4.3.80) but Battery/AC lines are still too far to the right, so right now line Battery: 1005 (charging) is partially overlapped by AC icon (flash). In Russian it will be much worse as strings tend to be longer. I do not understand why text starts about 1/3 of width from the left side. Is it intentional? Hm, that looks slightly broken indeed. It might be a bit better with the current version (again moved around the widgets a bit). Can you send me a screenshot of how it looks like in current trunk? I'm a bit afraid that we won't be able to do much about it without losing the alignment again, as elided buttons look really bad, IMO. I'd like to have a look though. One question, maybe it's possible to use shorter names for "sleep" resp. "hibernate"? I can neither read nor write the language used there, and it's probably also not a structural fix. This kind of text should be as short as possible though... Created attachment 38980 [details] battery widget in 4.3.80 (In reply to comment #4) I attach how it looks in 4.3.80. Buttons layout is IMHO OK (actually it was already). It the layout of Battery/AC Adapter strings that is a bit off. Yep, the text overlapping the battery icon is problematic. I'll have a go at fixing this. (I know the problem is because the battery on the right is actually outside the layout.) Created attachment 39786 [details]
Battery popup in 4.4 RC1
Unfortunately is not getting better :(
Created attachment 41049 [details]
4.4.0
Whoops, premature pressing of enter. The text is fine now (at least for English), combo box is broken now. The blue highlight isn't rendered around the right and bottom of the button and the menu is rendered underneath the panel. Compositing has no effect. Please disregard previous posts Found bug 219873 confirming the bug. In Russian it is very hard to translate 'Hibernate' and 'Sleep' shortly in a way that is understandable by an average person, so currently the translation is long. Please adjust the layout code so that it works as expected in the case when hibernate/sleep buttons taking a lot of space. (i.e. make battery icon stick to the right) if you give me a hint to where the code is, I could try to fix it myself. Hi Nick, The code is in kdebase/workspace/plasma/generic/applets/battery/battery.cpp (if I'm not mistaken as to the path). From what I can see, the following needs to happen (if you don't get to it, don't worry, this is also handy as personal note for me ;-)): - Sleep button needs a sensible maximum size, so the text gets elided, plus a tooltip so the user can get at the full text - The battery in the popup should sit in an anchorlayout and be anchored to the top-right corner Cheers, and thanks for your patience! sebas: the layout of the applet change quite a lot since this report i think it can be closed? Initial problem (misplaced battery icon) still remains. We still have the problem that some languagages cannot translate the buttons on the left in a short enough way, so the problem persists. I'll try to improve before 4.5 comes out. This one's been fixed by Aurelien. |