Bug 214963

Summary: [patch] kdm does not default to correct shutdown commands
Product: [Unmaintained] kdm Reporter: David Naylor <naylor.b.david>
Component: generalAssignee: kdm bugs tracker <kdm-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: rakuco
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: FreeBSD Ports   
OS: FreeBSD   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description David Naylor 2009-11-17 13:47:08 UTC 
Version:            (using KDE 4.3.3)
Compiler:          gcc (GCC) 4.2.1 20070719  [FreeBSD] 
OS:                FreeBSD
Installed from:    FreeBSD Ports

genkdmconf does default to the correct values however, unless the command is explicitly set in kdmrc, the shutdown command defaults to the Linux onces (which are incorrect for a BSD system).  

This results as <sys/param.h> is not included before <config.ci>, as a result BSD is not defined (except in the case of genkdmconf.c).  

The following patch makes sure <sys/param.h> is included so BSD is defined (if available):

--- kdm/config.def
+++ kdm/config.def
@@ -32,6 +32,9 @@
 #define KDMCONF KDE_CONFDIR "/kdm"
 #define KDMDATA KDE_DATADIR "/kdm"
 
+#include <sys/param.h>  /* This is required for BSD define (how else will we
+                           known it exists?). */
+
 #ifdef _AIX
 # define HALT_CMD	"/usr/sbin/shutdown -h now"
 # define REBOOT_CMD	"/usr/sbin/shutdown -r now"
Comment 1 Oswald Buddenhagen 2010-02-21 12:00:25 UTC 
SVN commit 1093649 by ossi:

make config.ci self-contained

BUG: 214963

 M  +2 -0      config.def  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1093649
Comment 2 Raphael Kubo da Costa 2010-02-21 16:39:08 UTC 
SVN commit 1093855 by rkcosta:

Backport r1093649 by ossi

make config.ci self-contained

CCBUG: 214963


 M  +2 -0      config.def  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1093855