Bug 213766

Summary:	Playlist uses inadequate key for album cover art cache
Product:	[Applications] amarok	Reporter:	Matt Whitlock <kde>
Component:	Playlist	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED DUPLICATE
Severity:	normal
Priority:	NOR
Version:	2.2.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Matt Whitlock 2009-11-08 22:01:11 UTC

Version:           2.2.0 (using 4.3.3 (KDE 4.3.3), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.30-gentoo-r5

The playlist's album art cache is apparently keyed only by album title.  This means that when two tracks are in the playlist and both are from albums having the same name, both show the same album cover.

I believe this to be a distinct bug from bug 170146, which had to do more with the database representation of albums.  This bug is about display in the playlist.  The data in the back-end is correct.

See here for a screen shot demonstrating the bug:
http://img265.imageshack.us/img265/3360/amarokbug.png

(Apparently Amarok has an opinion of Miley Cyrus, but that's neither here nor there.)

Do note that the two tracks (the Resident Evil track and the Miley Cyrus track) are not displayed as though they are from the same album.  Amarok knows they're from different albums, even though both albums are titled "Soundtrack".  The only problem is that the album cover displayed for the second track is the wrong one.  When the Resident Evil track had finished playing and Amarok advanced to the Miley Cyrus track, the album cover displayed in the "Current Track" plasmoid was the correct one for Miley Cyrus, but the two tracks in the playlist both still showed the Resident Evil cover.

Comment 1 Myriam Schweingruber 2009-11-09 11:09:12 UTC


*** This bug has been marked as a duplicate of bug 170146 ***

Comment 2 Matt Whitlock 2009-11-09 18:54:01 UTC

Myriam, I hope you read my report before you marked it as a duplicate.  I specifically made the case for why this is unrelated to the problem described in bug 170146.

Comment 3 Myriam Schweingruber 2009-11-09 20:36:13 UTC

And why would this not be related? Both the collection and the playlist use the same data.

Comment 4 Matt Whitlock 2009-11-09 21:06:13 UTC

I could be way off base, but it seems like bug 170146 is about an inadequacy in the database representation of album covers.  My point is that the database apparently has it correct, at least as of Amarok 2.2.0, since the correct album cover is displayed in the "Current Track" plasmoid while the track is playing, but Amarok's in-memory album cover cache is using an insufficient key, such that cache entries for multiple distinct albums are colliding.  If my interpretation of bug 170146 is incorrect, then I apologize for all the noise I've been making.  Regardless, all that matters is that you know what's wrong.  Thanks for looking into it.

Comment 5 Mark Kretschmann 2009-11-10 18:18:04 UTC

Matt, we did some changes to the cover handling in 2.2.1. Please stay tuned for this version, then test again.

Thanks :)