Bug 213594

Summary: plasmaengineexplorer scroll problem when viewing last entry in list
Product: [Plasma] plasma4 Reporter: Roman Fietze <kde>
Component: generalAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: asraniel
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: openSUSE   
OS: Unspecified   
Latest Commit: Version Fixed In:
Attachments: explorer window after an update of selected data source
Proposed patch to cure the problem

Description Roman Fietze 2009-11-07 21:05:23 UTC 
Version:            (using KDE 4.3.3)
Installed from:    openSUSE RPMs

When trying to view the last entry in the list of data sources, the plasmaengineexplorer always scrolls up in a way, that only the first line of the selected data source is visible, but not its entries.

See the example screen shot of this application. During thge time between two refrehs I scroll all the way down so I can see all Local's entries. But every time the update happens, the explorer scrolls the main window as shown in the attachment.
Comment 1 Roman Fietze 2009-11-07 21:07:06 UTC 
Created attachment 38162 [details]
explorer window after an update of selected data source
Comment 2 Roman Fietze 2009-11-10 22:17:59 UTC 
Created attachment 38242 [details]
Proposed patch to cure the problem

The bad scroll operation seems to be caused by first removing all items, then adding them again.

I'm almost totally new to Qt/KDE programming, so there might be a better solution than what I did.
Comment 3 Beat Wolf 2009-11-14 11:47:35 UTC 
could you submitt the patch to reviewboard.kde.org ? thank you
Comment 4 Roman Fietze 2009-11-14 14:54:39 UTC 
(In reply to comment #3)

> could you submitt the patch to reviewboard.kde.org ? thank you

The documentation says: General Workflow: ... If they’re ready for it to go in:
Submit your change to the repository.

I cannot do that, I do not have write access to the repos, and I don't know if that really would make sense, esp. when I think of the small amount of patches I will be able to supply at all. So, what shall I do with the review results?
Comment 5 Beat Wolf 2009-11-14 14:58:07 UTC 
as i said, please submit your patch to reviewboard.kde.org and state that you don't have a svn access, so that if the patch is commited, someone else can commit it. thank you
Comment 6 Aaron J. Seigo 2009-11-16 19:42:23 UTC 
SVN commit 1050140 by aseigo:

better updating of entries; patch by Roman Fietze
BUG:213594


 M  +7 -5      engineexplorer.cpp  
 M  +1 -1      engineexplorer.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1050140