Summary: | collection scanner fails on SQL INSERT if LANG is not English | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Benedikt Waldvogel <kde-bugzilla> |
Component: | Collections/Local | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | mitchell |
Priority: | NOR | ||
Version: | 2.3-GIT | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Benedikt Waldvogel
2009-11-01 23:47:05 UTC
After all, why aren't prepared statements used? Creating the SQL statement by hand is a very bad idea IMO. CC'ing Jeff Mitchell, who knows the scanner code best. Jeff, any ideas? :) Prepared statements aren't used because they won't provide any sort of a significant speedup and are a total and complete pain in the ass in the C API. Also I don't see how prepared statements are even related to this bug, considering the problem is bad data being passed in, not the query itself. Regardless, it should be fixed in 6685d27. Please let me know. Thanks for your work Jeff, but I still get the very same ERROR. More debugging needed? Don't know what to say. I just tested it and it's fixed for me. You sure you're using a new enough version from git? What is the exact ERROR you get in the debug output? It might be something new; please repaste from debug output. Also please tell me what git version you're using. It's entirely possible that you built a version from Git but aren't actually using it (or it's using the wrong libraries), due to your PATH or LDPATH. The problem seems to be fixed for me since e38986b54701. Thanks Jeff! |