Bug 212663

Summary:	+ sign next to the cursor always appears while drag and dropping a contact
Product:	[Applications] kaddressbook	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	VERIFIED FIXED
Severity:	normal	CC:	tokoe
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Sabine Faure 2009-11-01 21:36:58 UTC

Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch Kontact and go to KAB
- Create two address books (AB1 and AB2)
- Create a new contact in AB1 (ex: John Smith)
- Start moving the contact within AB1 and a forbidden sign should appear next to the cursor to show that this action will not work.
- Now start moving the contact to AB2 and a + sign appears next to the cursor. It stays there even if you hold the Shift key whereas I think it should disappear since you are moving the contact and not copying it, Right?
In any case, there is a consistency pb: if you hold the Shift key before starting to move the contact then the + sign does not appear.

- Now start moving the contact to another address book and a + sign appears next to the cursor again. It stays there wheither you hold the Ctrl key or not which I think is not the proper behaviour.
Moreover, if you hold the Ctrl key before starting to move the contact it does not change anything making the user wonder why holding the key is necessary.
However, if no key is held then the pop up menu appears asking the user to choose between ''Move'' and ''Copy'' the contact and the + sign stays next to the cursor at all time.

Tobias could you confirm to me which + sign behaviour is the correct one and check out the consistency pb?

Trunk, Svn Rev 1043144

Comment 1 Tobias Koenig 2009-11-04 11:21:50 UTC

SVN commit 1044599 by tokoe:

Pass the correct default action to the drag object,
so that the action icon is set correctly.

BUG: 212663


 M  +11 -1     dragdropmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1044599

Comment 2 Sabine Faure 2009-11-05 17:23:41 UTC

It is corrected now.

Moving contacts using the shortcut : when holding the Shift key there is a forbidden sign over a contact card symbol or over a two pages symbol (if moving several contacts) next to the cursor, until it is possible to move the contact (i.e. an address book is chosen). Then there is only the contact card symbol or the two pages symbol next to the cursor. 
The contact is moved correctly.

Copying contacts using the shortcut: when holding the Ctrl key there is a forbidden sign over a contact card symbol or a two pages symbol (if moving several contacts) next to the cursor, until it is possible to move it (i.e. an address book is chosen). Then there is a + sign over the contact card or the two pages symbol next to the cursor.
The contact is copied correctly.

Trunk, Svn Rev 1045165