Bug 211873

Summary:	What to do about the lines between connected pieces?
Product:	[Applications] palapeli	Reporter:	Stefan Majewsky <majewsky>
Component:	general	Assignee:	Stefan Majewsky <majewsky>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde-games-bugs-null
Priority:	LO
Version First Reported In:	unspecified
Target Milestone:	1.0
Platform:	openSUSE
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Stefan Majewsky 2009-10-26 00:32:31 UTC

Version:            (using KDE 4.3.2)
Installed from:    openSUSE RPMs

Bug 211828 suggests that the thin lines that separate two connected tiles are a "feature" that should be configurable.

Actually, this has never been a feature, but a rendering error. I've now grown accustomed to it, but I still try to kill it every now and then (since one and a half year, without any success).

Comment 1 Ian Wadham 2009-10-28 07:48:29 UTC

Naively perhaps, this might be related to a similar problem KGoldrunner had, where all tiles unexpectedly received an unpainted outline-area after a new version of Qt 4 came out.  The solution was to get the bounding QRectF of the pixmap and use QRectF::adjust to add 0.5 of a pixel on all four sides before rendering the graphics object into it.  See trunk/KDE/kdegames/kgoldrunner/kgrtheme.cpp at KGrTheme::loadGraphic() for details.

Comment 2 Stefan Majewsky 2009-10-28 14:54:16 UTC

@Ian: Nope, QGraphicsPixmapItem does that automatically. Because the pieces are not layed out relative to each other, but relative to the top-left corner to the puzzle, such an outline should not cause any problems.

Comment 3 Stefan Majewsky 2009-11-05 11:34:10 UTC

SVN commit 1045065 by majewsky:

Finally fix the ugly-lines-between-pieces bug: I forgot that QPens are cosmetic by default.
BUG: 211873



 M  +1 -1      slicer-jigsaw.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1045065