| Summary: | Raw import tool decoding twice | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Bartek Pietrasiak <pietras.sp> |
| Component: | Plugin-RawImport-Native | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, marcel.wiesweg, wolfi |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | 1.1.0 | |
| Sentry Crash Report: | |||
|
Description
Bartek Pietrasiak
2009-10-24 19:12:23 UTC
which digiKam version ? rev.: 1039758 When you load with the Raw import tool, the first "loading" is preview loading, only the second loading process, after clicking "Import", is the real one. The result of the latter is cached. The image is cached without color correction. If only choosing a different profile has no effect although it should, please prepare a testcase to reproduce this. To confirm color management bugs, either use two profiles widely apart like sRGB and a wide gamut profile, or take screenshots. What is the difference beetwen this preview and normal decoding? (some half mode like dcraw -h?) It took me a while, but I've found it. Please try the following: 1. F4 on some raw (canon 400D in my case) 2. Please change only the curve 3. Click Import 4. Go to digikam and F4 on this same file 5. Again change only the curve 6. Click import. Raw decoding wan't be started this time and you will is previous result. yes, preview is an half size decoded raw image Gilles Caulier The same problem for other params in post processing tab. No. All post processing option re-use half decoded image to process adjustments. Image is not re-decoded to render preview. There is a cache in import tool dedicated for that in import tool. And yes image is decoded 2 time to import RAW in editor : 1- One time as half image to reduce loading time and render preview 2- One time with all final parameters to process high size image import Note : the cache from import tool used to store locally half decoded image is not shared with the rest of digiKam. It just used internally to speed up preview rendering in import tool. There is another (general) cache in digiKam, shared with all the rest of digiKam and used to store full raw image size imported in editor. Gilles Caulier SVN commit 1063940 by mwiesweg: Implement operator== for DRawDecoding. CCBUG: 211681 M +11 -0 drawdecoding.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1063940 I can confirm, and it's not fixed, the commit was only one step. SVN commit 1067520 by mwiesweg: Update to cache key mechanism to our current needs. Add a "hint" to LoadingDescription about the kind of raw decoding settings. This simplifies things for non-raws. For raws with custom settings, it's now clear that the cache key alone is not sufficient. CCBUG: 211681 219748 M +102 -31 loadingdescription.cpp M +24 -5 loadingdescription.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1067520 SVN commit 1067521 by mwiesweg: When needed - when loading with custom or global settings - check that the DRawDecoding settings of requested and cached image are identical. CCBUG: 211681, 219748 M +17 -3 loadsavetask.cpp M +16 -3 previewtask.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1067521 *** Bug 219748 has been marked as a duplicate of this bug. *** SVN commit 1067526 by mwiesweg: Always give the correct RawDecodingHint to the loading descriptions. This should ensure that the raw decoding settings are compared in detail before retrieving an image from the cache. BUG: 211681 M +2 -1 NEWS M +1 -1 libs/imageproperties/imagepropertiescolorstab.cpp M +7 -3 libs/threadimageio/previewloadthread.cpp M +23 -11 utilities/imageeditor/canvas/dimginterface.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1067526 |