| Summary: | (patch) Dolphin doesn't preview favicon .ico files | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | skierpage <info> |
| Component: | general | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, faure |
| Priority: | NOR | Keywords: | investigated, junior-jobs |
| Version: | SVN | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.6.5 | |
| Sentry Crash Report: | |||
|
Description
skierpage
2009-10-23 00:12:20 UTC
In fact the "Preview This File" is a (broken?) entry to show the image in the "Previewer" widget in Plasma Desktop :
dolphin(29440)/kio (KRun) runTempService: runTempService: KProcess args=
("/usr/bin/qdbus", "org.kde.plasma", "/Previewer",
"org.kde.Previewer.openFile", "/home/skierpage/Desktop/google_favicon.ico")
Service 'org.kde.plasma' does not exist.
It seems to be broken (never worked for me). And that should be filed in another bug report I think.
About the icon itself not being previewed in Dolphin, there is a related bug report: bug 107491 ("add support for windows icons", with a supplied patch to implement icon previewing for "ico" and even "exe")
Regards
(In reply to comment #1) Thanks for analyzing! > In fact the "Preview This File" is a (broken?) entry to show the image in the > "Previewer" widget in Plasma Desktop : > ... > It seems to be broken (never worked for me). And that should be filed in > another bug report I think. You're right this is a separate bug -- Preview This File fails for me for all file types. There's a bug 190388 about this but even if I add the Previewer plasma widget that menu item fails. > About the icon itself not being previewed in Dolphin, there is a related bug > report: bug 107491 ("add support for windows icons", with a supplied patch to > implement icon previewing for "ico" and even "exe") That seems like overkill (handling multiple icon sizes, parsing executables) just for previewing the favicon web standard, and the patch seems to introduce depencies on `wrestool` and `icotool` executables from an icotools package that I don't have even though I have Wine installed, with no fallback. Since other parts of KDE render .ico fine, maybe just adding image/vnd.microsoft.icon; and image/x-icon; to MimeType in /usr/share/kde4/services/imagethumbnail.desktop is enough to get something working. (I guess I have to restart KDE4 to see if this takes...) (In reply to comment #2) > Since other parts of KDE render .ico fine, maybe just adding > image/vnd.microsoft.icon; and image/x-icon; to MimeType in > /usr/share/kde4/services/imagethumbnail.desktop is enough to get something > working. I made this 1-line change, adding them after image/x-ico;, and logged out of K Desktop. Upon logging back in, a) and c) are fixed, in Dolphin and Konqeror favicon.ico files in local directories have the small 16x16 preview you would expect! Please consider making this tiny change to kdebase/runtime/kioslave/thumbnail/imagethumbnail.desktop. @@ -86,7 +86,8 @@ Name[zh_CN]=图像 Name[zh_TW]=影像 X-KDE-ServiceTypes=ThumbCreator -MimeType=image/cgm;image/fax-g3;image/gif;image/jp2;image/png;image/tiff;image/bmp;image/x-dds;image/x-ico;image/x-jng;image/x-pcx;image/x-photo-cd;image/x-portable-bitmap;image/x-portable-graymap;image/x-portable-pixmap;image/x-rgb;image/x-tga;image/x-wmf;image/x-xbitmap;image/x-xcf;image/x-xfig;image/x-xpixmap; +MimeType=image/cgm;image/fax-g3;image/gif;image/jp2;image/png;image/tiff;image/bmp;image/x-dds;image/x-ico;image/vnd.microsoft.icon;image/x-icon;image/x-jng;image/x-pcx;image/x-photo-cd;image/x-portable-bitmap;image/x-portable-graymap;image/x-portable-pixmap;image/x-rgb;image/x-tga;image/x-wmf;image/x-xbitmap;image/x-xcf;image/x-xfig;image/x-xpixmap; X-KDE-Library=imagethumbnail CacheThumbnail=true X-Ubuntu-Gettext-Domain=desktop_kdebase-runtime Some notes: the official MIME type is image/vnd.microsoft.icon , but many web sites return a Content-Type: image/x-icon , so I added both. According to /usr/share/mime/aliases and /usr/share/mime/image/vnd.microsoft.icon.xml, the existing image/x-ico in imagethumbnail.desktop is an alias of image/vnd.microsoft.icon , but clearly Dolphin doesn't consult aliases. "Preview This File" and dragging into the Previewer plasma widget still don't work for .ico files. Thanks for taking the time to investigate this. I closed the other bug report as it was implemented already, I'm going to leave this open so one dev can look at it. Regards Git commit 1749449fa96ac3a64896eaa94688cba5dea11a04 by Dawit Alemayehu. Committed on 05/06/2011 at 20:28. Pushed by adawit into branch 'KDE/4.6'. Added preview support for ICO files. BUG: 211491 FIXED-IN: 4.6.5 M +1 -1 kioslave/thumbnail/imagethumbnail.desktop http://commits.kde.org/kde-runtime/1749449fa96ac3a64896eaa94688cba5dea11a04 Git commit c3a85e529bb68a1b09a56a8598f2488b345ffa09 by Dawit Alemayehu. Committed on 05/06/2011 at 20:28. Pushed by adawit into branch 'master'. Added preview support for ICO files. BUG: 211491 FIXED-IN: 4.6.5 (cherry picked from commit 1749449fa96ac3a64896eaa94688cba5dea11a04) M +1 -1 kioslave/thumbnail/imagethumbnail.desktop http://commits.kde.org/kde-runtime/c3a85e529bb68a1b09a56a8598f2488b345ffa09 |