Bug 211237

Summary: Advanced rename: only one shot
Product: [Applications] digikam Reporter: Bartek Pietrasiak <pietras.sp>
Component: AdvancedRename-dialogAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 1.0.0   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed In: 1.0.0

Description Bartek Pietrasiak 2009-10-20 19:26:40 UTC 
Version:           rev.: 1037924 (using KDE 4.3.2)
OS:                Linux
Installed from:    Fedora RPMs

I can only do one reanema. After that, digikam still complains that he cannot change e.g. test2.jpg with test2.jpg even I change the pattern and even I change the collections. I have to restart it to make another rename.
Comment 1 Bartek Pietrasiak 2009-10-22 17:58:43 UTC 
It seems not to occur until you try to use the same pattern again, so that the error is displayed for the first time. After that, you always get the error.
Comment 2 Andi Clemens 2009-10-22 18:11:06 UTC 
It only occurs when you use file names that are already assigned.
The KDE popup will come to tell you to chose another name and you seem to press cancel then.
I'm already aware of this problem and work on it.
Comment 3 Andi Clemens 2009-10-22 18:55:49 UTC 
SVN commit 1039077 by aclemens:

Fix error handling in AdvancedRename.
Since we use KIO for this, real error handling is not necessary. Just make sure
that we cleanup the list on failed renaming, too (wakeAll())
CCBUG:211237

 M  +7 -4      digikam/digikamimageview.cpp  
 M  +14 -25    digikam/imageviewutilities.cpp  
 M  +4 -3      digikam/imageviewutilities.h  
 M  +16 -16    utilities/advancedrename/advancedrenamedialog.cpp  
 M  +4 -4      utilities/advancedrename/advancedrenamedialog.h  
 M  +19 -2     utilities/advancedrename/common/renamethread.cpp  
 M  +3 -2      utilities/advancedrename/common/renamethread.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039077
Comment 4 Andi Clemens 2009-10-22 18:56:39 UTC 
Bartek,

can you check with latest SVN code?
Comment 5 Andi Clemens 2009-10-22 19:31:12 UTC 
I just renamed 50.000 images, I have not seen any issue...
Comment 6 Bartek Pietrasiak 2009-10-22 23:22:53 UTC 
Fortunately, I didn't have 50.000 images during test therefore I had to click the cancel button only 125 times :] Seems to be ok now. But can you add some cancel button which will break the whole renaming process?
Comment 7 Andi Clemens 2009-10-23 00:19:39 UTC 
SVN commit 1039187 by aclemens:

Abort renaming when canceling a nameconflict or overwrite dialog.
CCBUG:211237

 M  +3 -0      digikam/digikamimageview.cpp  
 M  +10 -2     digikam/imageviewutilities.cpp  
 M  +1 -0      digikam/imageviewutilities.h  
 M  +1 -1      utilities/advancedrename/common/renamethread.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039187
Comment 8 Andi Clemens 2009-10-23 00:37:22 UTC 
I guess this report can be closed, feel free to add comments if still something is wrong.