Bug 211160

Summary:	Wrong pkgconfig (.pc) files in kdebindings
Product:	[Unmaintained] bindings	Reporter:	Lukáš Krejza <gryffus>
Component:	general	Assignee:	kde-bindings
Status:	RESOLVED FIXED
Severity:	normal	CC:	arno
Priority:	NOR	Keywords:	investigated, needs_verification
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Fix pkgconfig references and dll install paths

Description Lukáš Krejza 2009-10-20 01:16:12 UTC

Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

Pkgconfig files in kde csharp bindings should contain full path so mono will be able to identify assemblies.

Files affected:
http://websvn.kde.org/?view=revision&revision=929133

Example for qyoto.pc:
Libs: -r:qt-dotnet          is wrong and should be:
Libs: -r:${libdir}/mono/2.0/qt-dotnet.dll

Also we should't be putting assemblies in ${libdir}/mono/2.0/* but instead in ${libdir}/mono/qt-dotnet/*. Should i create separate bugreport for this? Also the .pc files must reflect this...

Comment 1 Arno Rehn 2009-10-20 15:36:21 UTC

Libs: -r:${libdir}/mono/2.0/qt-dotnet.dll
This will break on Debian and derivates because they have a different GAC structure/location.

Furthermore putting assemblies in ${libdir}/mono/qt-dotnet/ will break referencing with -r:qt-dotnet . Mono itself puts 3rd party libs like ICSharpCode.SharpZipLib, Sql# or NUnit in the 2.0 folder - so why shouldn't we do that as well?

Comment 2 Lukáš Krejza 2009-10-20 16:45:21 UTC

(In reply to comment #1)
> Libs: -r:${libdir}/mono/2.0/qt-dotnet.dll
> This will break on Debian and derivates because they have a different GAC
> structure/location.
> 
> Furthermore putting assemblies in ${libdir}/mono/qt-dotnet/ will break
> referencing with -r:qt-dotnet . Mono itself puts 3rd party libs like
> ICSharpCode.SharpZipLib, Sql# or NUnit in the 2.0 folder - so why shouldn't we
> do that as well?

[16:40] <lluis> "3rd party libraries shouldn't go to ${libdir}/mono/2.0. Mono only puts there lirbaries which are required by mono itself. qt-dotnet should be moved to ${libdir}/mono/qt-dotnet, and referenced using -pkg:qt-dotnet instead of -r:qt-dotnet."

Comment 3 Arno Rehn 2009-10-20 16:51:32 UTC

Hm, ok. If that's their policy I think we should change it. I don't know if it will be fixed with 4.4, but it should definitely be in 4.5 then.

Comment 4 Lukáš Krejza 2009-10-20 17:51:12 UTC

Created attachment 37687 [details]
Fix pkgconfig references and dll install paths

Please review this patch i don't know cmake stuff much...
Thank you

Comment 5 Arno Rehn 2009-12-23 16:55:27 UTC

This should be fixed now in trunk. The new C# macros take care of correct paths in the pkg-config files.

Comment 6 Lukáš Krejza 2009-12-23 17:08:58 UTC

Great!