| Summary: | crash when saving images in editor | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Paolo Masulli <paolo.masulli> |
| Component: | Portability-Runtime | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | andresbajotierra, caulier.gilles, meldavid, paolo.masulli |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | Version Fixed In: | 1.0.0 | |
| Sentry Crash Report: | |||
| Attachments: |
gdb output
Debugview output Patch with KUrl |
||
|
Description
Paolo Masulli
2009-10-18 14:34:06 UTC
Yes, we need a backtrace. Gilles This link could help you: http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_on_MS_Windows Regards Tried to test this here, but the code path hitting the error condition in EditorWindow::setupTempSaveFile does not lead to a freeze here. So I can't reproduce. Created attachment 37743 [details]
gdb output
Created attachment 37745 [details]
Debugview output
(In reply to comment #2) > This link could help you: > http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_on_MS_Windows > > Regards I tried to follow these instructions. I attached the files NABUCCO.LOG from Debugview and gdb.txt from gdb. Unfortunately this backtrace is not helpful, looks broken. I'm sorry I have never debugged on Windows. I can confirm both problems. I think the first is related to bug #205341. KUrl:directory() uses path() and not toLocalFile so it gives a starting / with KDE 4.3. This can be seen in otrher places to, like in image information in right sidebar where Directory is given and it also starts with a /. The second problem may not be just a Digikam problem since for me Kate also crashes the same way on Save as. When run under gdb I get the following: Program received signal SIGSEGV, Segmentation fault. 0x09afc659 in KFileDialog (this=0x2479cc90, startDir=@0x23bb4c, filter=@0x23bc74, parent=0x22f74490, customWidget=0x22431a30) at C:\kde\kde-mingw4-stable\build\kde-4.3\kdelibs-20080202\work\kdelibs-4.3.2\kio\kfile\kfiledialog.cpp:238 238 in C:\kde\kde-mingw4-stable\build\kde-4.3\kdelibs-20080202\work\kdelibs-4.3.2\kio\kfile\kfiledialog.cpp I am running KDE 4.3.2 mingw4 from installer with self-compiled Digikam. Yes: under windows, KDE 4.3.2, I can reproduce the crash with kate and showfoto when File/Open is used... Gilles Caulier Gilles, is this a kdelibs crash? Any improvement after the coding sprint work on Windows? No more crash with KDE 4.3.4 and digikam from svn. However both Save and Save As gives problem 1. This is since KUrl::directory() uses KUrl::path(). Is it possible to change it to toLocalFile() and use the whole filename as start for the temporaryfile? Marcel, As David said, ye i think it's solved now in kdelibs Gilles It seems to me now that KUrl::directory() is pretty useless for local files, there is no proper replacement method (like "toLocalDirectory") What should we use to emulate this? KUrl parent(url.directory()); parent.toLocalFile(); QFileInfo info(url.toLocalFile()); info.dir().path(); Created attachment 39131 [details]
Patch with KUrl
This must be fixed before release. The attached patch uses Marcels first suggestion. It works for me with both Save and Save As.
SVN commit 1063417 by cgilles: apply patch #39131 BUGS: 210969 M +6 -0 editorwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1063417 |