Bug 210967

Summary:	Deleting left image in Light Table in Pair mode jumps to next pair [patch]
Product:	[Applications] digikam	Reporter:	kgw
Component:	LightTable-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, languitar
Priority:	NOR
Version:	1.0.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:	7.6.0
Attachments:	Patch to not try to set the right panel active in pair mode

Description kgw 2009-10-18 14:19:17 UTC

Version:            (using KDE 4.3.2)
Installed from:    Compiled From Sources

Instead of moving the right image to the left slot and taking the next available one to the right the next pair is selected the image previously selected into the right half of the view is discarded to the left of the list... So in fact by looking at the descriptions in the code case:
1)  A_L  B_R  C    D   ->   B_L  C_R  D
Works out as 
1)  A_L  B_R  C    D   ->   B  C_L  D_R

Comment 1 kgw 2009-10-18 23:35:58 UTC

Additional information: This seems to happen outside of LightTableWindow::slotRemoveItem as the items determined for the left and right hand side of the light table are correct...

Comment 2 kgw 2009-10-18 23:55:24 UTC

Further debugging reveals that slotRemoveItem is the culprit after all. In pair mode always the left item is active but the slot tries to set the right item active after the deletion, which in pair mode moves the selection one item to the right... Please can anyone confirm that the correct way of handling this case would be not to set the leftPanelActive variable to false in pair mode as this case IMHO can't happen...

Comment 3 kgw 2009-10-19 00:44:47 UTC

Created attachment 37656 [details]
Patch to not try to set the right panel active in pair mode

For me this now works as intended...

Comment 4 caulier.gilles 2009-10-19 08:56:21 UTC

Thanks for the patch. We will review it soon

Gilles Caulier

Comment 5 Johannes Wienke 2009-10-22 01:57:31 UTC

Is this the same issue that I just fixed for 211366?

Comment 6 caulier.gilles 2009-10-22 09:09:01 UTC

In the idea yes, but look patch attached to this file...

Gilles

Comment 7 kgw 2009-10-22 09:24:20 UTC

@Johannes: I looked at your patch, it does fix a problem but not this one
though, this arises later while the effects of the deletion is evaluated - see
my patch attached below...

Comment 8 Johannes Wienke 2009-10-22 11:18:09 UTC

SVN commit 1038901 by jwienke:

Applied patch from  kgw@mineralien-verkauf.de that improves light table behaviour when deleting images. Thanks for the patch.

BUG: 210967

 M  +2 -1      NEWS  
 M  +5 -2      utilities/lighttable/lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1038901