| Summary: | Allow immediate deleting of images without diverting through the "trash-folder" [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | kgw |
| Component: | Database-Trash | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, languitar, marcel.wiesweg |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | 1.0.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Patch to add deletion without trash via SHIFT+DEL and Toolbar in Lighttable
Patch to add deletion without trash via SHIFT+DEL and Toolbar in Lighttable |
||
|
Description
kgw
2009-10-17 20:41:20 UTC
Sorry, meant this to be a wish list item... Already implemented, like in every other KDE application, just press SHIFT+DEL. Andi Sorry, but then this doesn't work! I just tried in the Light Table to delete an image by pressing SHIFT and DEL and it does nothing! Created attachment 37747 [details]
Patch to add deletion without trash via SHIFT+DEL and Toolbar in Lighttable
The patch doesn't compile, in lighttablewindow.cpp you added a "3" in the copyright comment which makes the file invalid :-) For me the patch is not working, due to the following errors: 1) The normal delete method (trash delete, Del key) is dead now 2) pressing Shift+Del will call the "trash delete" method :-) Can anyone confirm? @Andi, sorry abouth the 3 sneaking into the patch... As to the other problems, it works for me...as for the DEL-key no longer working: You are correct, I just don't know why, I didn't remove the relevant code, I just added the proposed key sequence of SHIFT+DEL. The trash is not used when pressing SHIFT+DEL though... Created attachment 37750 [details]
Patch to add deletion without trash via SHIFT+DEL and Toolbar in Lighttable
Corrected Version, I had added two actions under the same name into the actionCollection ().
SVN commit 1039943 by aclemens: Add permanent delete action to the light table as well. Kgw, I have altered your patch a lot, it had code duplication that was actually not necessary. Can we close this bug now? Andi CCBUG:210907 M +33 -5 lighttablewindow.cpp M +6 -0 lighttablewindow.h M +2 -0 lighttablewindow_p.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1039943 @Andi, I didn't quite understand the semantics of the dialog quite, will the two ways to delete result in different confirmation dialogs? What I mean is, I might want to use the move to trash without and the delete file with confirmation. I might have gotten it wrong as well as I don't get the dialog anymore on both, but I don't know where to reset the question to appear at all... Besides this quibble the bug could be closed. (In reply to comment #9) > @Andi, I didn't quite understand the semantics of the dialog quite, will the > two ways to delete result in different confirmation dialogs? Yes, it will result in the same dialogs as in AlbumUI, one for delete, the other for trash action. What I mean is, I > might want to use the move to trash without and the delete file with > confirmation. I might have gotten it wrong as well as I don't get the dialog > anymore on both, but I don't know where to reset the question to appear at > all... Besides this quibble the bug could be closed. Delete will always need confirmation, for the trash action you can set a checkbox for "Never ask again". To revert this, go into Settings->Misc->Confirm move to trash Ok I will close the bug now. Andi @Andi, it may be fine for you that the Delete always needs confirmation, for me this is a big nuisance I want to get rid o, is there a way to configure the confirmation dialog to be optional like the move to trash is? No there is no config option and I guess there will be none. We can not satisfy every user (:-)), and I can assure you that if this would be an option, we will get a lot of hate mails :-) A permanent delete is a very destructive action, and most users don't want their images to vanish that easy. Just imagine you press the key kombination for "permanently delete" and while you are doing this, you realize that this was a mistake. Boom... your images are gone. Moving them to trash without confirmation is not a big deal, you can restore it again. Or imagine you set this option once, but forget about it. Hitting "permanent delete" will not ask you again, and yes, although you might know what you are doing, others might not :-) So from my point of view, this will not be implemented. Gilles, Marcel, your opinion? Anyway just press Enter twice, shouldn't be that time consuming? Andi I can add such an option, let's hope we get no bugreports like "please, warn user on permanent delete" :D @Andi: Don't. I'll patch it for my use, I agree with your reluctance to add this option... No, I'm adding it already. Gilles and co think it might be useful. The default is set to confirm, and I just saw that dolphin has such a "dangerous" checkbox, too. SVN commit 1040051 by aclemens: Use "Do not ask again" option for permanent delete as well. This is a global setting, not only true for lighttable. CCBUG:210907 M +19 -5 digikam/albumsettings.cpp M +3 -0 digikam/albumsettings.h M +35 -10 libs/dialogs/deletedialog.cpp M +3 -2 libs/dialogs/deletedialog.h M +17 -15 utilities/setup/setupmisc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1040051 |