Bug 210837

Version:           2.2-GIT (using KDE 4.3.2)
OS:                Linux
Installed from:    Archlinux Packages

I've two related problem with adding and removing albums from various artists.

Problem one:
When I add an album to various artists and an album with the same same already exists under various, there will be an extra album in the list.

Problem two:
Remove an album from various artists, sometimes result in an empty album under various artists, but the tracks will be under the right artist under the right album.

I've made a patch that should fix this problem and I hope one of the amarok developers will look at it. I'll attach it in a moment.

The problem is caused in SqlAlbum::setCompilation() which are marked AMAROK_NOTIMPLEMENTED.

Solution for problem one:
There is a constraint on album.name and album.artist in the database, but if artist is NULL multiple entries of the same name can exist in the database.
I simply check for existing albums with the same name and artist is null, if such an album exist, add the tracks to that album.

Solution for problem two:
The same constraint as problem one plays in here.
The problems was primarily caused by attempting to update an album to having the same name and artist as another album, and there were no check to prevent this.

But the code also assumed the artist for the first track in the album, was also the artist for all the other tracks. This wasn't the case with tracks I had from four different albums all called "Greatest hits".

I solved these by checking for artist for each track in the album, against other album with the same name and moving the tracks to those albums.