Bug 210798

Summary: [PATCH] Amarok 2.2.0: Lyrics applet displays previous title, if no lyrics are found
Product: [Applications] amarok Reporter: Michal Ziabkowski <mziab>
Component: generalAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal CC: lfranchi, martin.blumenstingl
Priority: NOR    
Version: 2.2.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: patch which might solve this problem

Description Michal Ziabkowski 2009-10-16 16:57:51 UTC 
Version:           2.2.0 (using 4.3.2 (KDE 4.3.2), Gentoo)
Compiler:          i686-pc-linux-gnu-gcc
OS:                Linux (i686) release 2.6.31-gentoo-r3

Steps to reproduce:
1) Play a song which has lyrics
2) Make sure the Lyrics applet is displayed
2) Skip to a song with no available lyrics

Result:
The header of the applet displays the name of the last song which had lyrics.

Expected result:
If no lyrics can be found, the header displays "Lyrics"

Amarok 2.2.0
Qt: 4.5.3
KDE: 4.3.2 (KDE 4.3.2)

I can confirm it happens with both LyricWiki and UltimateLyrics scripts, so it's most probably a problem with the applet, not with the scripts.
Comment 1 Martin Blumenstingl 2009-11-18 20:42:58 UTC 
Created attachment 38428 [details]
patch which might solve this problem

Hi,

could you please test this patch and tell me if this fixes your problem?
Comment 2 Myriam Schweingruber 2009-11-18 21:31:24 UTC 
draklight, please make a merge request on Gitorious as described here: 

http://techbase.kde.org/Getting_Started/Sources/KDE_git-tutorial#Patch_Contributors

Asking users to test your patches is not the way this should be done.
Also, since this report is about 2.2.0, did you make sure this is not already fixed in 2.2.1?
Comment 3 Martin Blumenstingl 2009-11-18 21:38:28 UTC 
Hi Myriam,

in theory this was fixed with commit c49b6a32886af29334c4825210bdd9d8eba2ade2
so you were right, I should have checked that first :)

this won't work if there's a bug in LyricsApplet's code (or the lyrics engine sends unknown data)
my patch would also catch that... but I'm not sure how likely that is ;)

if you still want me to open a merge request I'll do that - please just ping me again
Comment 4 Myriam Schweingruber 2009-11-18 22:03:04 UTC 
(In reply to comment #3)
> Hi Myriam,
> 
> in theory this was fixed with commit c49b6a32886af29334c4825210bdd9d8eba2ade2
> so you were right, I should have checked that first :)
> 
> this won't work if there's a bug in LyricsApplet's code (or the lyrics engine
> sends unknown data)
> my patch would also catch that... but I'm not sure how likely that is ;)
> 
> if you still want me to open a merge request I'll do that - please just ping me
> again

I am not a developer, just a triager, so you better ask on the devel list :)
Comment 5 Martin Blumenstingl 2009-11-19 23:56:13 UTC 
Hi,

just sent a mail to the mailing list ;)
would you then please close this bug (as the original bug itself is already fixed)?
Comment 6 Myriam Schweingruber 2009-11-20 12:52:58 UTC 
OK, thx.
Comment 7 Michal Ziabkowski 2009-11-21 20:12:21 UTC 
Indeed, after upgrading to 2.1.1 darklight's patch seems to fix the issue.