Bug 210607

Summary:	DCC crash when cancelling duplicate filename dialog
Product:	[Applications] konversation	Reporter:	Eike Hein <hein>
Component:	dcc	Assignee:	Konversation Bugs <konversation-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash
Priority:	NOR
Version First Reported In:	Git
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Crash backtrace Shell debug output

Description Eike Hein 2009-10-14 23:17:59 UTC

With two incoming file transfers using the same file name, and auto-accept on, Konvi will pop up a dialog asking what to do about the dupe. Pressing Cancel in this dialog crashes the app.

Comment 1 Eike Hein 2009-10-15 00:15:16 UTC

Created attachment 37585 [details]
Crash backtrace

Comment 2 Eike Hein 2009-10-15 00:18:57 UTC

Created attachment 37586 [details]
Shell debug output

Comment 3 Dario Andres 2009-10-16 23:07:47 UTC

Pasting backtrace inline:
---

Application: Konversation (konversation), signal: Segmentation fault
[Current thread is 1 (Thread 0x7fe463ef6820 (LWP 3553))]

Thread 2 (Thread 0x7fe459a67910 (LWP 3558)):
#0  0x000000359c40b2f9 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0
#1  0x000000338385adfb in QWaitCondition::wait(QMutex*, unsigned long) () from /usr/lib64/libQtCore.so.4
#2  0x0000003384e81b74 in ?? () from /usr/lib64/libQtNetwork.so.4
#3  0x0000003383859d45 in ?? () from /usr/lib64/libQtCore.so.4
#4  0x000000359c40686a in start_thread () from /lib64/libpthread.so.0
#5  0x000000359b8de3bd in clone () from /lib64/libc.so.6
#6  0x0000000000000000 in ?? ()

Thread 1 (Thread 0x7fe463ef6820 (LWP 3553)):
[KCrash Handler]
#5  0x0000000003326110 in ?? ()
#6  0x00000033856eecd9 in KJob::kill(KJob::KillVerbosity) () from /usr/lib64/libkdecore.so.5
#7  0x00000000005b9a8f in Konversation::DCC::TransferRecv::slotLocalCanResume (this=0x3625170, job=0x32bb850, size=0) at /home/sho/kdevel/4/src/konversation/src/dcc/transferrecv.cpp:393
#8  0x00000000005bc1ce in Konversation::DCC::TransferRecv::qt_metacall (this=0x3625170, _c=QMetaObject::InvokeMetaMethod, _id=4, _a=0x7fff42cb4fd0)
    at /home/sho/kdevel/4/build/konversation/src/transferrecv.moc:99
#9  0x0000003383953e1c in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib64/libQtCore.so.4
#10 0x0000003386ce73bb in KIO::TransferJob::canResume(KIO::Job*, unsigned long long) () from /usr/lib64/libkio.so.5
#11 0x0000003386cece45 in KIO::TransferJob::qt_metacall(QMetaObject::Call, int, void**) () from /usr/lib64/libkio.so.5
#12 0x0000003383953e1c in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib64/libQtCore.so.4
#13 0x0000003386dac952 in KIO::SlaveInterface::canResume(unsigned long long) () from /usr/lib64/libkio.so.5
#14 0x0000003386db03a4 in KIO::SlaveInterface::dispatch(int, QByteArray const&) () from /usr/lib64/libkio.so.5
#15 0x0000003386dacdb3 in KIO::SlaveInterface::dispatch() () from /usr/lib64/libkio.so.5
#16 0x0000003386d9fbed in KIO::Slave::gotInput() () from /usr/lib64/libkio.so.5
#17 0x0000003386da1cfc in KIO::Slave::qt_metacall(QMetaObject::Call, int, void**) () from /usr/lib64/libkio.so.5
#18 0x0000003383953e1c in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib64/libQtCore.so.4
#19 0x0000003386cbb277 in ?? () from /usr/lib64/libkio.so.5
#20 0x0000003386cbb38d in KIO::Connection::qt_metacall(QMetaObject::Call, int, void**) () from /usr/lib64/libkio.so.5
#21 0x000000338394e191 in QObject::event(QEvent*) () from /usr/lib64/libQtCore.so.4
#22 0x0000003383f8f63c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
#23 0x0000003383f9689e in QApplication::notify(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
#24 0x0000003385e117f6 in KApplication::notify(QObject*, QEvent*) () from /usr/lib64/libkdeui.so.5
#25 0x000000338393ebfc in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib64/libQtCore.so.4
#26 0x000000338393f7d2 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/lib64/libQtCore.so.4
#27 0x0000003383967313 in ?? () from /usr/lib64/libQtCore.so.4
#28 0x000000359d43790e in g_main_context_dispatch () from /lib64/libglib-2.0.so.0
#29 0x000000359d43b0e8 in ?? () from /lib64/libglib-2.0.so.0
#30 0x000000359d43b20a in g_main_context_iteration () from /lib64/libglib-2.0.so.0
#31 0x0000003383966f86 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
#32 0x000000338402202e in ?? () from /usr/lib64/libQtGui.so.4
#33 0x000000338393d502 in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
#34 0x000000338393d8d4 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
#35 0x000000338393fa69 in QCoreApplication::exec() () from /usr/lib64/libQtCore.so.4
#36 0x000000000046959c in main (argc=1, argv=0x7fff42cb6b68) at /home/sho/kdevel/4/src/konversation/src/main.cpp:101

Comment 4 Bernd Buschinski 2009-10-17 00:35:59 UTC

SVN commit 1036287 by buschinski:

- Fix dcc crash for getting a tranfser twice(same name) and cancel one, KIO reuses TransferJobs, so we can't kill the job, just hold it and let KIO decide when it is really unused
BUG:210607
- Fix transferpanel crash for the cases:
	+ cleanCompleted and never had a transfer in the panel
	+ multi-selected transfers, clear, not all transfers were cleared, but panel transfer got deleted



 M  +3 -3      transferpanel.cpp  
 M  +6 -3      transferrecv.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1036287